Cleanups after adopting g_get_*_dir()

[libvirt] [PATCH 36/42] locking: Use g_autofree on virLockManagerLockDaemonPath()

Posted by Fabiano Fidêncio 6 years, 1 month ago

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 src/locking/lock_driver_lockd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c
index e8f0329b05..8ca77e525d 100644
--- a/src/locking/lock_driver_lockd.c
+++ b/src/locking/lock_driver_lockd.c
@@ -122,14 +122,12 @@ static char *virLockManagerLockDaemonPath(bool privileged)
     if (privileged) {
         path = g_strdup(RUNSTATEDIR "/libvirt/virtlockd-sock");
     } else {
-        char *rundir = NULL;
+        g_autofree char *rundir = NULL;
 
         if (!(rundir = virGetUserRuntimeDirectory()))
             return NULL;
 
         path = g_strdup_printf("%s/virtlockd-sock", rundir);
-
-        VIR_FREE(rundir);
     }
     return path;
 }
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 36/42] locking: Use g_autofree on virLockManagerLockDaemonPath()

Posted by Ján Tomko 6 years, 1 month ago

s/on/in/

On Thu, Dec 19, 2019 at 11:04:41AM +0100, Fabiano Fidêncio wrote:
>Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
>---
> src/locking/lock_driver_lockd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list