Cleanups after adopting g_get_*_dir()

[libvirt] [PATCH 32/42] logging: Use g_autofree on virLogManagerDaemonPath()

Posted by Fabiano Fidêncio 6 years, 1 month ago

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 src/logging/log_manager.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/logging/log_manager.c b/src/logging/log_manager.c
index e191093272..7a4f036240 100644
--- a/src/logging/log_manager.c
+++ b/src/logging/log_manager.c
@@ -47,14 +47,12 @@ virLogManagerDaemonPath(bool privileged)
     if (privileged) {
         path = g_strdup(RUNSTATEDIR "/libvirt/virtlogd-sock");
     } else {
-        char *rundir = NULL;
+        g_autofree char *rundir = NULL;
 
         if (!(rundir = virGetUserRuntimeDirectory()))
             return NULL;
 
         path = g_strdup_printf("%s/virtlogd-sock", rundir);
-
-        VIR_FREE(rundir);
     }
     return path;
 }
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 32/42] logging: Use g_autofree on virLogManagerDaemonPath()

Posted by Ján Tomko 6 years, 1 month ago

s/on/in/

On Thu, Dec 19, 2019 at 11:04:37AM +0100, Fabiano Fidêncio wrote:
>Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
>---
> src/logging/log_manager.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list