Cleanups after adopting g_get_*_dir()

[libvirt] [PATCH 26/42] secret: Don't check the output of virGetUserRuntimeDirectory()

Posted by Fabiano Fidêncio 6 years, 1 month ago

virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 src/secret/secret_driver.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c
index cdc4b7dcf9..096672f114 100644
--- a/src/secret/secret_driver.c
+++ b/src/secret/secret_driver.c
@@ -478,8 +478,7 @@ secretStateInitialize(bool privileged,
         cfgdir = virGetUserConfigDirectory();
         driver->configDir = g_strdup_printf("%s/secrets/", cfgdir);
 
-        if (!(rundir = virGetUserRuntimeDirectory()))
-            goto error;
+        rundir = virGetUserRuntimeDirectory();
         driver->stateDir = g_strdup_printf("%s/secrets/run", rundir);
     }
 
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 26/42] secret: Don't check the output of virGetUserRuntimeDirectory()

Posted by Ján Tomko 6 years, 1 month ago

On Thu, Dec 19, 2019 at 11:04:31AM +0100, Fabiano Fidêncio wrote:
>virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the
>checks for it completely unnecessary.
>
>Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
>---
> src/secret/secret_driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list