Cleanups after adopting g_get_*_dir()

[libvirt] [PATCH 20/42] logging: Use g_autofree on virLogDaemonConfigFilePath()

Posted by Fabiano Fidêncio 6 years, 1 month ago

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 src/logging/log_daemon_config.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c
index 0cf9729e7f..ab42921140 100644
--- a/src/logging/log_daemon_config.c
+++ b/src/logging/log_daemon_config.c
@@ -42,13 +42,12 @@ virLogDaemonConfigFilePath(bool privileged, char **configfile)
     if (privileged) {
         *configfile = g_strdup(SYSCONFDIR "/libvirt/virtlogd.conf");
     } else {
-        char *configdir = NULL;
+        g_autofree char *configdir = NULL;
 
         if (!(configdir = virGetUserConfigDirectory()))
             goto error;
 
         *configfile = g_strdup_printf("%s/virtlogd.conf", configdir);
-        VIR_FREE(configdir);
     }
 
     return 0;
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 20/42] logging: Use g_autofree on virLogDaemonConfigFilePath()

Posted by Ján Tomko 6 years, 1 month ago

s/on/in/

On Thu, Dec 19, 2019 at 11:04:25AM +0100, Fabiano Fidêncio wrote:
>Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
>---
> src/logging/log_daemon_config.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list