conf: avoid mem leak re-allocating fake NUMA capabilities

[libvirt] [PATCH] conf: avoid mem leak re-allocating fake NUMA capabilities

Daniel P. Berrangé posted 1 patch 4 years, 4 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191218115756.760817-1-berrange@redhat.com

src/conf/capabilities.c | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH] conf: avoid mem leak re-allocating fake NUMA capabilities

Posted by Daniel P. Berrangé 4 years, 4 months ago

The 'caps' object is already allocated when the fake NUMA
initialization takes place.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/conf/capabilities.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index 4fac59e6f7..81a2004dba 100644
--- a/src/conf/capabilities.c
+++ b/src/conf/capabilities.c
@@ -1628,9 +1628,6 @@ virCapabilitiesHostNUMAInitFake(virCapsHostNUMAPtr caps)
         }
     }
 
-    caps = g_new0(virCapsHostNUMA, 1);
-    caps->cells = g_ptr_array_new_with_free_func(
-        (GDestroyNotify)virCapabilitiesFreeHostNUMACell);
     virCapabilitiesHostNUMAAddCell(caps, 0,
                                    nodeinfo.memory,
 #ifdef __linux__
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: avoid mem leak re-allocating fake NUMA capabilities

Posted by Daniel Henrique Barboza 4 years, 4 months ago


On 12/18/19 8:57 AM, Daniel P. Berrangé wrote:
> The 'caps' object is already allocated when the fake NUMA
> initialization takes place.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list