With this series applied, running

  ./lcitool dockerfile libvirt-opensuse-151 libvirt

results in a Dockerfile that can be successfully used to build a
container image, and that image in turn can be successfully used
to build libvirt in.

Andrea Bolognani (5):
  guests: Add mapping for augeas-lenses
  guests: Install augeas-lenses for libvirt
  lcitool: Remove redundant update step for openSUSE
  guests: Add base container image for openSUSE Leap 15.1
  lcitool: Make Dockerfile generation work on openSUSE

 guests/host_vars/libvirt-opensuse-151/docker.yml |  2 ++
 guests/lcitool                                   | 14 ++++++++++++--
 guests/playbooks/update/tasks/base.yml           |  7 -------
 guests/vars/mappings.yml                         |  5 +++++
 guests/vars/projects/libvirt.yml                 |  1 +
 5 files changed, 20 insertions(+), 9 deletions(-)
 create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> With this series applied, running
>
>   ./lcitool dockerfile libvirt-opensuse-151 libvirt
>
> results in a Dockerfile that can be successfully used to build a
> container image, and that image in turn can be successfully used
> to build libvirt in.
>
> Andrea Bolognani (5):
>   guests: Add mapping for augeas-lenses
>   guests: Install augeas-lenses for libvirt
>   lcitool: Remove redundant update step for openSUSE
>   guests: Add base container image for openSUSE Leap 15.1
>   lcitool: Make Dockerfile generation work on openSUSE
>
>  guests/host_vars/libvirt-opensuse-151/docker.yml |  2 ++
>  guests/lcitool                                   | 14 ++++++++++++--
>  guests/playbooks/update/tasks/base.yml           |  7 -------
>  guests/vars/mappings.yml                         |  5 +++++
>  guests/vars/projects/libvirt.yml                 |  1 +
>  5 files changed, 20 insertions(+), 9 deletions(-)
>  create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml
>
> --
> 2.23.0
>

There's one suggestion in the last patch. Please, take a look at that
and feel free to adopt the suggestion or not.

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, 2019-12-12 at 15:45 +0100, Fabiano Fidêncio wrote:
> On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani <abologna@redhat.com> wrote:
> > Andrea Bolognani (5):
> >   guests: Add mapping for augeas-lenses
> >   guests: Install augeas-lenses for libvirt
> >   lcitool: Remove redundant update step for openSUSE
> >   guests: Add base container image for openSUSE Leap 15.1
> >   lcitool: Make Dockerfile generation work on openSUSE
> 
> There's one suggestion in the last patch. Please, take a look at that
> and feel free to adopt the suggestion or not.
> 
> Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

Thanks, I've pushed the series now. I'm confident Jim will point out
any silly mistake I might have made because of my lack of experience
with openSUSE :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 12/12/19 8:31 AM, Andrea Bolognani wrote:
> On Thu, 2019-12-12 at 15:45 +0100, Fabiano Fidêncio wrote:
>> On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani <abologna@redhat.com> wrote:
>>> Andrea Bolognani (5):
>>>    guests: Add mapping for augeas-lenses
>>>    guests: Install augeas-lenses for libvirt
>>>    lcitool: Remove redundant update step for openSUSE
>>>    guests: Add base container image for openSUSE Leap 15.1
>>>    lcitool: Make Dockerfile generation work on openSUSE
>>
>> There's one suggestion in the last patch. Please, take a look at that
>> and feel free to adopt the suggestion or not.
>>
>> Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
> 
> Thanks, I've pushed the series now. I'm confident Jim will point out
> any silly mistake I might have made because of my lack of experience
> with openSUSE :)

It looks good to me! Thanks for taking care of one of the tasks on my list :-).

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list