[libvirt] [PATCH] ci: Fix VPATH builds

Andrea Bolognani posted 1 patch 4 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191212095429.423883-1-abologna@redhat.com
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] ci: Fix VPATH builds
Posted by Andrea Bolognani 4 years, 4 months ago
The CI build machinery is intentionally not handled by autotools,
so for VPATH builds - which are mandatory now - we need to make
sure we're looking into $(srcdir).

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 15df6ed68e..4edb3fdd43 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -148,4 +148,4 @@ gen-AUTHORS:
 	fi
 
 ci-%:
-	$(MAKE) -C ci/ $@
+	$(MAKE) -C $(srcdir)/ci/ $@
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] ci: Fix VPATH builds
Posted by Daniel P. Berrangé 4 years, 4 months ago
On Thu, Dec 12, 2019 at 10:54:29AM +0100, Andrea Bolognani wrote:
> The CI build machinery is intentionally not handled by autotools,
> so for VPATH builds - which are mandatory now - we need to make
> sure we're looking into $(srcdir).
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list