[libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet

Andrea Bolognani posted 1 patch 4 years, 4 months ago
Failed in applying to current master (apply log)
jenkins/jobs/defaults.yaml            | 2 --
jenkins/projects/libosinfo.yaml       | 1 -
jenkins/projects/libvirt-dbus.yaml    | 2 --
jenkins/projects/libvirt.yaml         | 1 -
jenkins/projects/osinfo-db-tools.yaml | 1 -
jenkins/projects/virt-manager.yaml    | 3 ---
6 files changed, 10 deletions(-)
[libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
Posted by Andrea Bolognani 4 years, 4 months ago
We're currently waiting to see whether we can get more capacity
for our CI environment, and in the meantime we've decided not do
create additional builders on the existing machine.

In order to be able to deploy other configuration changes without
enabling CentOS 8 jobs at the same time, we need to temporarily
drop all mentions of the target from the Jenkins configuration:
once we've figured out where to create the CentOS 8 builder, we
can simply revert this patch.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 jenkins/jobs/defaults.yaml            | 2 --
 jenkins/projects/libosinfo.yaml       | 1 -
 jenkins/projects/libvirt-dbus.yaml    | 2 --
 jenkins/projects/libvirt.yaml         | 1 -
 jenkins/projects/osinfo-db-tools.yaml | 1 -
 jenkins/projects/virt-manager.yaml    | 3 ---
 6 files changed, 10 deletions(-)

diff --git a/jenkins/jobs/defaults.yaml b/jenkins/jobs/defaults.yaml
index 9232d42..676ecbf 100644
--- a/jenkins/jobs/defaults.yaml
+++ b/jenkins/jobs/defaults.yaml
@@ -4,7 +4,6 @@
     node: libvirt
     all_machines:
       - libvirt-centos-7
-      - libvirt-centos-8
       - libvirt-debian-9
       - libvirt-debian-10
       - libvirt-fedora-30
@@ -14,7 +13,6 @@
       - libvirt-freebsd-12
     rpm_machines:
       - libvirt-centos-7
-      - libvirt-centos-8
       - libvirt-fedora-30
       - libvirt-fedora-31
       - libvirt-fedora-rawhide
diff --git a/jenkins/projects/libosinfo.yaml b/jenkins/projects/libosinfo.yaml
index cc7e024..819c5ac 100644
--- a/jenkins/projects/libosinfo.yaml
+++ b/jenkins/projects/libosinfo.yaml
@@ -15,7 +15,6 @@
           # RPM build is still not possible on CentOS7 as it does not
           # have the needed RPM macros for meson.
           machines:
-            - libvirt-centos-8
             - libvirt-fedora-30
             - libvirt-fedora-31
             - libvirt-fedora-rawhide
diff --git a/jenkins/projects/libvirt-dbus.yaml b/jenkins/projects/libvirt-dbus.yaml
index e71e2f9..dfc159c 100644
--- a/jenkins/projects/libvirt-dbus.yaml
+++ b/jenkins/projects/libvirt-dbus.yaml
@@ -15,7 +15,6 @@
           # Python3 version in Ubuntu 16.04 and python3-pytest version
           # in CentOS 7 are too old.
           machines:
-            - libvirt-centos-8
             - libvirt-debian-9
             - libvirt-debian-10
             - libvirt-fedora-30
@@ -26,7 +25,6 @@
           # RPM build is still not possible on CentOS7 as it does not
           # have the needed RPM macros for meson.
           machines:
-            - libvirt-centos-8
             - libvirt-fedora-30
             - libvirt-fedora-31
             - libvirt-fedora-rawhide
diff --git a/jenkins/projects/libvirt.yaml b/jenkins/projects/libvirt.yaml
index fa8fb89..fdc24bc 100644
--- a/jenkins/projects/libvirt.yaml
+++ b/jenkins/projects/libvirt.yaml
@@ -14,7 +14,6 @@
           # commands with more arguments than FreeBSD supports
           machines:
             - libvirt-centos-7
-            - libvirt-centos-8
             - libvirt-debian-9
             - libvirt-debian-10
             - libvirt-fedora-30
diff --git a/jenkins/projects/osinfo-db-tools.yaml b/jenkins/projects/osinfo-db-tools.yaml
index 7831df4..f28e72f 100644
--- a/jenkins/projects/osinfo-db-tools.yaml
+++ b/jenkins/projects/osinfo-db-tools.yaml
@@ -15,7 +15,6 @@
           # RPM build is still not possible on CentOS7 as it does not
           # have the needed RPM macros for meson.
           machines:
-            - libvirt-centos-8
             - libvirt-fedora-30
             - libvirt-fedora-31
             - libvirt-fedora-rawhide
diff --git a/jenkins/projects/virt-manager.yaml b/jenkins/projects/virt-manager.yaml
index 9c4c3bf..4524831 100644
--- a/jenkins/projects/virt-manager.yaml
+++ b/jenkins/projects/virt-manager.yaml
@@ -3,7 +3,6 @@
     name: virt-manager
     # CentOS 7 and Ubuntu 16.04 have Python 3 but not the libxml2 bindings
     machines:
-      - libvirt-centos-8
       - libvirt-debian-9
       - libvirt-debian-10
       - libvirt-fedora-30
@@ -27,7 +26,6 @@
           # so skip the test suite there for the time being. See
           # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224902
           machines:
-            - libvirt-centos-8
             - libvirt-debian-9
             - libvirt-debian-10
             - libvirt-fedora-30
@@ -36,7 +34,6 @@
       - python-distutils-rpm-job:
           parent_jobs: 'virt-manager-check'
           machines:
-            - libvirt-centos-8
             - libvirt-fedora-30
             - libvirt-fedora-31
             - libvirt-fedora-rawhide
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
Posted by Fabiano Fidêncio 4 years, 4 months ago
On Thu, Dec 12, 2019 at 9:54 AM Andrea Bolognani <abologna@redhat.com> wrote:
>
> We're currently waiting to see whether we can get more capacity
> for our CI environment, and in the meantime we've decided not do
> create additional builders on the existing machine.
>
> In order to be able to deploy other configuration changes without
> enabling CentOS 8 jobs at the same time, we need to temporarily
> drop all mentions of the target from the Jenkins configuration:
> once we've figured out where to create the CentOS 8 builder, we
> can simply revert this patch.

At this point I'd rather disable CentOS 7 builds than not enable CentOS 8.
Anyways, Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

Best Regards,
-- 
Fabiano Fidêncio


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
Posted by Andrea Bolognani 4 years, 4 months ago
On Thu, 2019-12-12 at 10:00 +0100, Fabiano Fidêncio wrote:
> On Thu, Dec 12, 2019 at 9:54 AM Andrea Bolognani <abologna@redhat.com> wrote:
> > We're currently waiting to see whether we can get more capacity
> > for our CI environment, and in the meantime we've decided not do
> > create additional builders on the existing machine.
> > 
> > In order to be able to deploy other configuration changes without
> > enabling CentOS 8 jobs at the same time, we need to temporarily
> > drop all mentions of the target from the Jenkins configuration:
> > once we've figured out where to create the CentOS 8 builder, we
> > can simply revert this patch.
> 
> At this point I'd rather disable CentOS 7 builds than not enable CentOS 8.

I get where you're coming from, but on the other hand CentOS 8 has
much fresher software so we're likely to catch most issues affecting
it through Fedora. Anyway, hopefully within a couple of weeks we'll
figure out where we stand on the new machine and we'll be able to
have both CentOS 7 and CentOS 8 running! :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
Posted by Daniel P. Berrangé 4 years, 4 months ago
On Thu, Dec 12, 2019 at 10:00:42AM +0100, Fabiano Fidêncio wrote:
> On Thu, Dec 12, 2019 at 9:54 AM Andrea Bolognani <abologna@redhat.com> wrote:
> >
> > We're currently waiting to see whether we can get more capacity
> > for our CI environment, and in the meantime we've decided not do
> > create additional builders on the existing machine.
> >
> > In order to be able to deploy other configuration changes without
> > enabling CentOS 8 jobs at the same time, we need to temporarily
> > drop all mentions of the target from the Jenkins configuration:
> > once we've figured out where to create the CentOS 8 builder, we
> > can simply revert this patch.
> 
> At this point I'd rather disable CentOS 7 builds than not enable CentOS 8.

Definitely not. CentOS 7 builder CI is one of the most successful targets
at finding bugs. CentOS 8 is very similar to other modern distros we're
testing, so it doesn't add significant coverage.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
Posted by Andrea Bolognani 4 years, 4 months ago
On Thu, 2019-12-12 at 10:23 +0000, Daniel P. Berrangé wrote:
> On Thu, Dec 12, 2019 at 10:00:42AM +0100, Fabiano Fidêncio wrote:
> > At this point I'd rather disable CentOS 7 builds than not enable CentOS 8.
> 
> Definitely not. CentOS 7 builder CI is one of the most successful targets
> at finding bugs. CentOS 8 is very similar to other modern distros we're
> testing, so it doesn't add significant coverage.

And, once we merge Dan's patches, the only one where we build the
vz driver.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
Posted by Daniel P. Berrangé 4 years, 4 months ago
On Thu, Dec 12, 2019 at 11:45:08AM +0100, Andrea Bolognani wrote:
> On Thu, 2019-12-12 at 10:23 +0000, Daniel P. Berrangé wrote:
> > On Thu, Dec 12, 2019 at 10:00:42AM +0100, Fabiano Fidêncio wrote:
> > > At this point I'd rather disable CentOS 7 builds than not enable CentOS 8.
> > 
> > Definitely not. CentOS 7 builder CI is one of the most successful targets
> > at finding bugs. CentOS 8 is very similar to other modern distros we're
> > testing, so it doesn't add significant coverage.
> 
> And, once we merge Dan's patches, the only one where we build the
> vz driver.

FWIW, if we want to free up more resources, I would suggest culling the
most recent Fedora stable release.

The overlap between  Fedora N-1 and Fedora rawhide should identify
anything that would impact current Fedora N.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list