[v2] Remove deprecated pc-0.x machine types and related hacks

[libvirt] [PATCH v2 0/4] Remove deprecated pc-0.x machine types and related hacks

Posted by Thomas Huth 4 years, 4 months ago

These have been on the deprecation list since a year now, so it's
time to finally remove the pc-0.x machine types.

We then can also remove some compatibility hacks in the devices, i.e.
the "use_broken_id" in ac97, the "command_serr_enable" in PCI devices
and the "rombar" stuff in VGA devices.

v2:
 - Minor updates to the first patch (fix comment, add deprecation_reason
   message for the pc-1.x machines)
 - Keep the QEMU_PCI_CAP_SERR enum in the third patch
 - Added fourth patch to remove the "rombar" hacks from the VGA devices

Thomas Huth (4):
  hw/i386: Remove the deprecated machines 0.12 up to 0.15
  hw/audio: Remove the "use_broken_id" hack from the AC97 device
  hw/pci: Remove the "command_serr_enable" property
  hw/display: Remove "rombar" hack from vga-pci and vmware_vga

 hw/audio/ac97.c         |  9 -----
 hw/display/vga-pci.c    |  5 ---
 hw/display/vga.c        |  4 +-
 hw/display/vmware_vga.c |  5 ---
 hw/i386/pc_piix.c       | 85 +----------------------------------------
 hw/pci/pci.c            |  6 +--
 include/hw/pci/pci.h    |  2 +-
 qemu-deprecated.texi    |  2 +-
 tests/cpu-plug-test.c   |  6 +--
 9 files changed, 7 insertions(+), 117 deletions(-)

-- 
2.18.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] Remove deprecated pc-0.x machine types and related hacks

Posted by no-reply@patchew.org 4 years, 4 months ago

Patchew URL: https://patchew.org/QEMU/20191209125248.5849-1-thuth@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Cloning into 'dtc'...
remote: Counting objects: 5280, done.        
error: RPC failed; result=18, HTTP code = 200
fatal: The remote end hung up unexpectedly
fatal: protocol error: bad pack header
Clone of 'https://git.qemu.org/git/dtc.git' into submodule path 'dtc' failed
failed to update submodule dtc
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) unregistered for path 'dtc'
make[1]: *** [/var/tmp/patchew-tester-tmp-x_fnqco1/src/docker-src.2019-12-09-13.13.54.13964] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-x_fnqco1/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    4m48.507s
user    0m2.457s


The full log is available at
http://patchew.org/logs/20191209125248.5849-1-thuth@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] Remove deprecated pc-0.x machine types and related hacks

Posted by no-reply@patchew.org 4 years, 4 months ago

Patchew URL: https://patchew.org/QEMU/20191209125248.5849-1-thuth@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Cloning into 'dtc'...
remote: Counting objects: 5280, done.        
error: RPC failed; result=18, HTTP code = 200
fatal: The remote end hung up unexpectedly
fatal: protocol error: bad pack header
Clone of 'https://git.qemu.org/git/dtc.git' into submodule path 'dtc' failed
failed to update submodule dtc
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) unregistered for path 'dtc'
make[1]: *** [/var/tmp/patchew-tester-tmp-9lcnuxat/src/docker-src.2019-12-09-13.19.18.7229] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-9lcnuxat/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    4m35.183s
user    0m2.657s


The full log is available at
http://patchew.org/logs/20191209125248.5849-1-thuth@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/4] Remove deprecated pc-0.x machine types and related hacks

Posted by Paolo Bonzini 4 years, 4 months ago

On 09/12/19 13:52, Thomas Huth wrote:
> These have been on the deprecation list since a year now, so it's
> time to finally remove the pc-0.x machine types.
> 
> We then can also remove some compatibility hacks in the devices, i.e.
> the "use_broken_id" in ac97, the "command_serr_enable" in PCI devices
> and the "rombar" stuff in VGA devices.
> 
> v2:
>  - Minor updates to the first patch (fix comment, add deprecation_reason
>    message for the pc-1.x machines)
>  - Keep the QEMU_PCI_CAP_SERR enum in the third patch
>  - Added fourth patch to remove the "rombar" hacks from the VGA devices
> 
> Thomas Huth (4):
>   hw/i386: Remove the deprecated machines 0.12 up to 0.15
>   hw/audio: Remove the "use_broken_id" hack from the AC97 device
>   hw/pci: Remove the "command_serr_enable" property
>   hw/display: Remove "rombar" hack from vga-pci and vmware_vga
> 
>  hw/audio/ac97.c         |  9 -----
>  hw/display/vga-pci.c    |  5 ---
>  hw/display/vga.c        |  4 +-
>  hw/display/vmware_vga.c |  5 ---
>  hw/i386/pc_piix.c       | 85 +----------------------------------------
>  hw/pci/pci.c            |  6 +--
>  include/hw/pci/pci.h    |  2 +-
>  qemu-deprecated.texi    |  2 +-
>  tests/cpu-plug-test.c   |  6 +--
>  9 files changed, 7 insertions(+), 117 deletions(-)
> 

Queued, thanks.

Paolo

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list