Add support for openSUSE

[libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

Posted by Jim Fehlig 4 years, 4 months ago

Jim Fehlig (2):
  guests: Add support for openSUSE
  guests: Add lci build support for openSUSE

 guests/configs/autoinst.xml                   | 77 +++++++++++++++++++
 .../host_vars/libvirt-opensuse-151/docker.yml |  2 +
 .../libvirt-opensuse-151/install.yml          |  2 +
 .../host_vars/libvirt-opensuse-151/main.yml   | 10 +++
 guests/inventory                              |  1 +
 guests/lcitool                                |  2 +
 guests/playbooks/build/jobs/defaults.yml      |  1 +
 guests/playbooks/build/projects/libvirt.yml   |  1 +
 guests/playbooks/update/tasks/base.yml        | 15 ++++
 guests/vars/mappings.yml                      | 38 ++++++++-
 10 files changed, 145 insertions(+), 4 deletions(-)
 create mode 100644 guests/configs/autoinst.xml
 create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml
 create mode 100644 guests/host_vars/libvirt-opensuse-151/install.yml
 create mode 100644 guests/host_vars/libvirt-opensuse-151/main.yml

-- 
2.24.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

Posted by Jim Fehlig 4 years, 4 months ago

On 12/6/19 4:44 PM, Jim Fehlig wrote:
> Jim Fehlig (2):
>    guests: Add support for openSUSE
>    guests: Add lci build support for openSUSE

I forgot to mention, 'lcitool update libvirt-opensuse-151 libvirt' still fails 
in the Configure hostname task

TASK [Configure hostname] 
**********************************************************************
fatal: [libvirt-opensuse-151]: FAILED! => {"changed": false, "msg": "hostname 
module cannot be used on platform Linux (Opensuse-leap)"}

> 
>   guests/configs/autoinst.xml                   | 77 +++++++++++++++++++
>   .../host_vars/libvirt-opensuse-151/docker.yml |  2 +
>   .../libvirt-opensuse-151/install.yml          |  2 +
>   .../host_vars/libvirt-opensuse-151/main.yml   | 10 +++
>   guests/inventory                              |  1 +
>   guests/lcitool                                |  2 +
>   guests/playbooks/build/jobs/defaults.yml      |  1 +
>   guests/playbooks/build/projects/libvirt.yml   |  1 +
>   guests/playbooks/update/tasks/base.yml        | 15 ++++
>   guests/vars/mappings.yml                      | 38 ++++++++-
>   10 files changed, 145 insertions(+), 4 deletions(-)
>   create mode 100644 guests/configs/autoinst.xml
>   create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml
>   create mode 100644 guests/host_vars/libvirt-opensuse-151/install.yml
>   create mode 100644 guests/host_vars/libvirt-opensuse-151/main.yml
> 


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

Posted by Fabiano Fidêncio 4 years, 4 months ago

On Sat, Dec 7, 2019 at 1:13 AM Jim Fehlig <jfehlig@suse.com> wrote:
>
> On 12/6/19 4:44 PM, Jim Fehlig wrote:
> > Jim Fehlig (2):
> >    guests: Add support for openSUSE
> >    guests: Add lci build support for openSUSE
>
> I forgot to mention, 'lcitool update libvirt-opensuse-151 libvirt' still fails
> in the Configure hostname task
>
> TASK [Configure hostname]
> **********************************************************************
> fatal: [libvirt-opensuse-151]: FAILED! => {"changed": false, "msg": "hostname
> module cannot be used on platform Linux (Opensuse-leap)"}

This is related to the ansible version you have in your machine.
I'm using ansible 2.9.1 and I can see, as part of
/usr/lib/python3.7/site-packages/ansible/modules/system/hostname.py:
```
class OpenSUSELeapHostname(Hostname):
    platform = 'Linux'
    distribution = 'Opensuse-leap'
    strategy_class = SystemdStrategy
```

Maybe it's worth a bug report in order to have it backported to the
ansible package you have in your distro.

The same goes with the patch I've submitted adding Opensuse-tumbleweed.

Best Regards,
-- 
Fabiano Fidêncio


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

Posted by Andrea Bolognani 4 years, 4 months ago

On Sat, 2019-12-07 at 16:51 +0100, Fabiano Fidêncio wrote:
> On Sat, Dec 7, 2019 at 1:13 AM Jim Fehlig <jfehlig@suse.com> wrote:
> > I forgot to mention, 'lcitool update libvirt-opensuse-151 libvirt' still fails
> > in the Configure hostname task
> > 
> > TASK [Configure hostname]
> > **********************************************************************
> > fatal: [libvirt-opensuse-151]: FAILED! => {"changed": false, "msg": "hostname
> > module cannot be used on platform Linux (Opensuse-leap)"}
> 
> This is related to the ansible version you have in your machine.
> I'm using ansible 2.9.1 and I can see, as part of
> /usr/lib/python3.7/site-packages/ansible/modules/system/hostname.py:
> ```
> class OpenSUSELeapHostname(Hostname):
>     platform = 'Linux'
>     distribution = 'Opensuse-leap'
>     strategy_class = SystemdStrategy
> ```
> 
> Maybe it's worth a bug report in order to have it backported to the
> ansible package you have in your distro.

The production environment has Ansible 2.8.4, which knows about Leap.

So we're good on that front, and Jim's issue is not a blocker for
inclusion as far as I'm concerned. He'll probably want to get it
fixed somehow, though :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list