Fix RPM deps for centos 7

[libvirt] [python PATCH] Fix RPM deps for centos 7

Posted by Daniel P. Berrangé 4 years, 4 months ago

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt-python.spec.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in
index 1e92f3c..33d2775 100644
--- a/libvirt-python.spec.in
+++ b/libvirt-python.spec.in
@@ -21,8 +21,13 @@ Url: http://libvirt.org
 License: LGPLv2+
 BuildRequires: libvirt-devel == %{version}
 BuildRequires: python3-devel
+%if 0%{?rhel} == 7
+BuildRequires: python36-nose
+BuildRequires: python36-lxml
+%else
 BuildRequires: python3-nose
 BuildRequires: python3-lxml
+%endif
 BuildRequires: gcc
 
 # Don't want provides for python shared objects
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [python PATCH] Fix RPM deps for centos 7

Posted by Andrea Bolognani 4 years, 4 months ago

On Wed, 2019-12-04 at 16:24 +0000, Daniel P. Berrangé wrote:
> +%if 0%{?rhel} == 7
> +BuildRequires: python36-nose
> +BuildRequires: python36-lxml
> +%else
>  BuildRequires: python3-nose
>  BuildRequires: python3-lxml
> +%endif

This should work just fine in an actual RHEL 7 machine, provided
that the user has installed the necessary Python 3 libraries through
EPEL and not for example Software Collections; I assume it would
simply fail to build in the latter case, which is not any worse than
what we had before.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list