virsh.pod: Mention iscsi-direct is supported in find-storage-pool-sources

[libvirt] [PATCH] virsh.pod: Mention iscsi-direct is supported in find-storage-pool-sources

Posted by Han Han 4 years, 4 months ago

Signed-off-by: Han Han <hhan@redhat.com>
---
 tools/virsh.pod | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index a8331154e1..14f4121787 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -3994,7 +3994,8 @@ any other provided XML elements in I<srcSpec>.
 For a "logical" pool, the contents of the I<srcSpec> file are ignored,
 although if provided the file must at least exist.
 
-For an "iscsi" pool, the minimal expect XML required is the <host> element
+For an "iscsi" or "iscsi-direct" pool,
+the minimal expect XML required is the <host> element
 with a "name" attribute describing the IP address or hostname to be used to
 find the pool (the iSCSI server address). Optionally, the "port" attribute
 may be provided, although it will default to 3260. Optionally, an <initiator>
-- 
2.24.0.rc1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh.pod: Mention iscsi-direct is supported in find-storage-pool-sources

Posted by Cole Robinson 4 years, 4 months ago

On 12/4/19 4:19 AM, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  tools/virsh.pod | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index a8331154e1..14f4121787 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -3994,7 +3994,8 @@ any other provided XML elements in I<srcSpec>.
>  For a "logical" pool, the contents of the I<srcSpec> file are ignored,
>  although if provided the file must at least exist.
>  
> -For an "iscsi" pool, the minimal expect XML required is the <host> element
> +For an "iscsi" or "iscsi-direct" pool,
> +the minimal expect XML required is the <host> element
>  with a "name" attribute describing the IP address or hostname to be used to
>  find the pool (the iSCSI server address). Optionally, the "port" attribute
>  may be provided, although it will default to 3260. Optionally, an <initiator>
> 

I adjusted this for the new .rst man page format, and pushed

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list