[libvirt] [PATCH] news: Fix XML validation

Jim Fehlig posted 1 patch 5 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191203040156.3486-1-jfehlig@suse.com
docs/news.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] news: Fix XML validation

Posted by Jim Fehlig 5 days ago
The news schema requires two digits for both month and day in the date
attribute. s/2/02/ in the day value of date to fix the following
'make check' failure

2165) Checking ../docs/news.xml against ../news.rng                     ...
libvirt: XML Util error : XML document failed to validate against schema:
Unable to validate doc against /home/jfehlig/virt/upstream/libvirt/build/../docs/schemas/../news.rng
Element release failed to validate attributes

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

Pushing under the build-breaker rule. One could argue the schema could
be relaxed, but let's fix the build first.

 docs/news.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/news.xml b/docs/news.xml
index 55b227839e..46a3466238 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -42,7 +42,7 @@
      -->
 
 <libvirt>
-  <release version="v5.10.0" date="2019-12-2">
+  <release version="v5.10.0" date="2019-12-02">
     <section title="New features">
       <change>
         <summary>
-- 
2.24.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: Fix XML validation

Posted by Andrea Bolognani 5 days ago
On Tue, 2019-12-03 at 04:02 +0000, Jim Fehlig wrote:
> The news schema requires two digits for both month and day in the date
> attribute. s/2/02/ in the day value of date to fix the following
> 'make check' failure
> 
> 2165) Checking ../docs/news.xml against ../news.rng                     ...
> libvirt: XML Util error : XML document failed to validate against schema:
> Unable to validate doc against /home/jfehlig/virt/upstream/libvirt/build/../docs/schemas/../news.rng
> Element release failed to validate attributes
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
> 
> Pushing under the build-breaker rule. One could argue the schema could
> be relaxed

Nah, it's fine as it is :)

Thanks for catching the issue and fixing it!

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: Fix XML validation

Posted by Daniel Veillard 5 days ago
  Dohhh, that's why :-) !
Thanks for chasing this Jim,

Daniel

On Tue, Dec 03, 2019 at 04:02:11AM +0000, Jim Fehlig wrote:
> The news schema requires two digits for both month and day in the date
> attribute. s/2/02/ in the day value of date to fix the following
> 'make check' failure
> 
> 2165) Checking ../docs/news.xml against ../news.rng                     ...
> libvirt: XML Util error : XML document failed to validate against schema:
> Unable to validate doc against /home/jfehlig/virt/upstream/libvirt/build/../docs/schemas/../news.rng
> Element release failed to validate attributes
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
> 
> Pushing under the build-breaker rule. One could argue the schema could
> be relaxed, but let's fix the build first.
> 
>  docs/news.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 55b227839e..46a3466238 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -42,7 +42,7 @@
>       -->
>  
>  <libvirt>
> -  <release version="v5.10.0" date="2019-12-2">
> +  <release version="v5.10.0" date="2019-12-02">
>      <section title="New features">
>        <change>
>          <summary>
> -- 
> 2.24.0
> 
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

-- 
Daniel Veillard      | Red Hat Developers Tools http://developer.redhat.com/
veillard@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list