[libvirt] [PATCH] src: fix pkg-config path for API XML files

Daniel P. Berrangé posted 1 patch 18 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191202131844.94474-1-berrange@redhat.com
src/libvirt-lxc.pc.in  | 2 +-
src/libvirt-qemu.pc.in | 2 +-
src/libvirt.pc.in      | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

[libvirt] [PATCH] src: fix pkg-config path for API XML files

Posted by Daniel P. Berrangé 18 weeks ago
The API XML files are generated files, so live in the build dir not the
source dir.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/libvirt-lxc.pc.in  | 2 +-
 src/libvirt-qemu.pc.in | 2 +-
 src/libvirt.pc.in      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/libvirt-lxc.pc.in b/src/libvirt-lxc.pc.in
index b9e131954b..27e3de4244 100644
--- a/src/libvirt-lxc.pc.in
+++ b/src/libvirt-lxc.pc.in
@@ -7,7 +7,7 @@ exec_prefix=@abs_top_builddir@
 libdir=@abs_top_builddir@/src/.libs
 includedir=@abs_top_builddir@/include
 source_includedir=@abs_top_srcdir@/include
-datarootdir=@abs_top_srcdir@
+datarootdir=@abs_top_builddir@
 
 libvirt_lxc_api=@datadir@/docs/libvirt-lxc-api.xml
 
diff --git a/src/libvirt-qemu.pc.in b/src/libvirt-qemu.pc.in
index 173ec5c50e..3eb9ad4bc1 100644
--- a/src/libvirt-qemu.pc.in
+++ b/src/libvirt-qemu.pc.in
@@ -7,7 +7,7 @@ exec_prefix=@abs_top_builddir@
 libdir=@abs_top_builddir@/src/.libs
 includedir=@abs_top_builddir@/include
 source_includedir=@abs_top_srcdir@/include
-datarootdir=@abs_top_srcdir@
+datarootdir=@abs_top_builddir@
 
 libvirt_qemu_api=@datadir@/docs/libvirt-qemu-api.xml
 
diff --git a/src/libvirt.pc.in b/src/libvirt.pc.in
index 9fe2f1f694..6ff1ce6272 100644
--- a/src/libvirt.pc.in
+++ b/src/libvirt.pc.in
@@ -7,7 +7,7 @@ exec_prefix=@abs_top_builddir@
 libdir=@abs_top_builddir@/src/.libs
 includedir=@abs_top_builddir@/include
 source_includedir=@abs_top_srcdir@/include
-datarootdir=@abs_top_srcdir@
+datarootdir=@abs_top_builddir@
 
 libvirt_api=@datadir@/docs/libvirt-api.xml
 
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: fix pkg-config path for API XML files

Posted by Pavel Hrdina 18 weeks ago
On Mon, Dec 02, 2019 at 01:18:44PM +0000, Daniel P. Berrangé wrote:
> The API XML files are generated files, so live in the build dir not the
> source dir.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/libvirt-lxc.pc.in  | 2 +-
>  src/libvirt-qemu.pc.in | 2 +-
>  src/libvirt.pc.in      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: fix pkg-config path for API XML files

Posted by Peter Krempa 18 weeks ago
On Mon, Dec 02, 2019 at 13:18:44 +0000, Daniel Berrange wrote:
> The API XML files are generated files, so live in the build dir not the
> source dir.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/libvirt-lxc.pc.in  | 2 +-
>  src/libvirt-qemu.pc.in | 2 +-
>  src/libvirt.pc.in      | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

ACK, I think I ran into this on friday when I attempted to build python
bindings.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list