travis: explicitly require xcode 10.3 image for macOS

[libvirt] [PATCH] travis: explicitly require xcode 10.3 image for macOS

Daniel P. Berrangé posted 1 patch 4 years, 4 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191127153848.29811-1-berrange@redhat.com

.travis.yml | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[libvirt] [PATCH] travis: explicitly require xcode 10.3 image for macOS

Posted by Daniel P. Berrangé 4 years, 4 months ago

The default macOS image in travis is broken, throwing python
exceptions when trying to install glib. Explicitly ask for the
newer 10.3 image which works correctly.

We now need to also point to the homebrew installed libxml2
rather than the OS distro provided one, since the OS distro
one has a pkg-config file present, but no actual header
files.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .travis.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 75f32e53b9..80f3be5490 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -62,8 +62,10 @@ matrix:
     - compiler: clang
       language: c
       os: osx
+      osx_image: xcode10.3
       env:
         - PATH="/usr/local/opt/gettext/bin:/usr/local/opt/ccache/libexec:/usr/local/opt/rpcgen/bin:$PATH"
+        - PKG_CONFIG_PATH="/usr/local/opt/libxml2/lib/pkgconfig"
       script:
         # We can't run 'distcheck' or 'syntax-check' because they fail on
         # macOS, but doing 'install' and 'dist' gives us some useful coverage
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] travis: explicitly require xcode 10.3 image for macOS

Posted by Pavel Hrdina 4 years, 4 months ago

On Wed, Nov 27, 2019 at 03:38:48PM +0000, Daniel P. Berrangé wrote:
> The default macOS image in travis is broken, throwing python
> exceptions when trying to install glib. Explicitly ask for the
> newer 10.3 image which works correctly.
> 
> We now need to also point to the homebrew installed libxml2
> rather than the OS distro provided one, since the OS distro
> one has a pkg-config file present, but no actual header
> files.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .travis.yml | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list