[libvirt] [PATCH] libxl: fix typo in error message

Daniel P. Berrangé posted 1 patch 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191126155933.1106992-1-berrange@redhat.com
src/libxl/libxl_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] libxl: fix typo in error message

Posted by Daniel P. Berrangé 1 week ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/libxl/libxl_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index e6c6f5f6ad..1e9d5dc875 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -2384,7 +2384,7 @@ libxlDriverNodeGetInfo(libxlDriverPrivatePtr driver, virNodeInfoPtr info)
 
     if (virStrcpyStatic(info->model, virArchToString(hostarch)) < 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("machine type %s too big for destination"),
+                       _("host arch %s too big for destination"),
                        virArchToString(hostarch));
         goto cleanup;
     }
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] libxl: fix typo in error message

Posted by Daniel Henrique Barboza 1 week ago

On 11/26/19 12:59 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   src/libxl/libxl_conf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index e6c6f5f6ad..1e9d5dc875 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -2384,7 +2384,7 @@ libxlDriverNodeGetInfo(libxlDriverPrivatePtr driver, virNodeInfoPtr info)
>   
>       if (virStrcpyStatic(info->model, virArchToString(hostarch)) < 0) {
>           virReportError(VIR_ERR_INTERNAL_ERROR,
> -                       _("machine type %s too big for destination"),
> +                       _("host arch %s too big for destination"),


Perhaps adding an "is" after the %s would make the message more 'natural to read'.
At least in my non native english speaker opinion.

Regardless, the typo per se is 'machine type' instead of 'host arch' and this
is getting fixed, so:

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>




>                          virArchToString(hostarch));
>           goto cleanup;
>       }
> 


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] libxl: fix typo in error message

Posted by Fabiano Fidêncio 1 week ago
On Tue, Nov 26, 2019 at 5:02 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/libxl/libxl_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index e6c6f5f6ad..1e9d5dc875 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -2384,7 +2384,7 @@ libxlDriverNodeGetInfo(libxlDriverPrivatePtr driver, virNodeInfoPtr info)
>
>      if (virStrcpyStatic(info->model, virArchToString(hostarch)) < 0) {
>          virReportError(VIR_ERR_INTERNAL_ERROR,
> -                       _("machine type %s too big for destination"),
> +                       _("host arch %s too big for destination"),
>                         virArchToString(hostarch));
>          goto cleanup;
>      }
> --
> 2.23.0

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list