[libvirt] [PATCH 0/2] Simplify hash table data free callbacks

Daniel P. Berrangé posted 2 patches 4 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191122120004.11685-1-berrange@redhat.com
src/conf/domain_addr.c              |  4 +--
src/conf/nwfilter_params.c          |  2 +-
src/conf/virchrdev.c                | 43 +++++++++++++++++++----------
src/conf/virdomainmomentobjlist.c   |  3 +-
src/conf/virnetworkobj.c            |  2 +-
src/libxl/libxl_logger.c            |  2 +-
src/locking/lock_daemon.c           |  3 +-
src/nwfilter/nwfilter_dhcpsnoop.c   |  4 +--
src/nwfilter/nwfilter_learnipaddr.c |  2 +-
src/qemu/qemu_block.c               |  3 +-
src/qemu/qemu_conf.c                |  4 +--
src/qemu/qemu_conf.h                |  2 +-
src/qemu/qemu_domain.c              |  3 +-
src/qemu/qemu_migration.c           |  3 +-
src/qemu/qemu_monitor.c             |  5 ++--
src/qemu/qemu_monitor.h             |  2 +-
src/qemu/qemu_monitor_json.c        |  2 +-
src/util/vircgroup.c                |  2 +-
src/util/virhash.c                  | 28 +++++--------------
src/util/virhash.h                  | 16 ++---------
src/util/virjson.c                  |  3 +-
src/util/virjson.h                  |  2 +-
src/util/virkeyfile.c               |  2 +-
src/util/virlockspace.c             |  2 +-
src/util/virobject.c                |  3 +-
src/util/virobject.h                |  3 +-
src/util/virsystemd.c               |  8 +++---
27 files changed, 70 insertions(+), 88 deletions(-)
[libvirt] [PATCH 0/2] Simplify hash table data free callbacks
Posted by Daniel P. Berrangé 4 years, 4 months ago
See the patch commit message for the interesting details.

Daniel P. Berrangé (2):
  conf: stop using hash key when free'ing hash entries
  util: consolidate on one free callback for hash data

 src/conf/domain_addr.c              |  4 +--
 src/conf/nwfilter_params.c          |  2 +-
 src/conf/virchrdev.c                | 43 +++++++++++++++++++----------
 src/conf/virdomainmomentobjlist.c   |  3 +-
 src/conf/virnetworkobj.c            |  2 +-
 src/libxl/libxl_logger.c            |  2 +-
 src/locking/lock_daemon.c           |  3 +-
 src/nwfilter/nwfilter_dhcpsnoop.c   |  4 +--
 src/nwfilter/nwfilter_learnipaddr.c |  2 +-
 src/qemu/qemu_block.c               |  3 +-
 src/qemu/qemu_conf.c                |  4 +--
 src/qemu/qemu_conf.h                |  2 +-
 src/qemu/qemu_domain.c              |  3 +-
 src/qemu/qemu_migration.c           |  3 +-
 src/qemu/qemu_monitor.c             |  5 ++--
 src/qemu/qemu_monitor.h             |  2 +-
 src/qemu/qemu_monitor_json.c        |  2 +-
 src/util/vircgroup.c                |  2 +-
 src/util/virhash.c                  | 28 +++++--------------
 src/util/virhash.h                  | 16 ++---------
 src/util/virjson.c                  |  3 +-
 src/util/virjson.h                  |  2 +-
 src/util/virkeyfile.c               |  2 +-
 src/util/virlockspace.c             |  2 +-
 src/util/virobject.c                |  3 +-
 src/util/virobject.h                |  3 +-
 src/util/virsystemd.c               |  8 +++---
 27 files changed, 70 insertions(+), 88 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/2] Simplify hash table data free callbacks
Posted by Michal Privoznik 4 years, 4 months ago
On 11/22/19 1:00 PM, Daniel P. Berrangé wrote:
> See the patch commit message for the interesting details.
> 
> Daniel P. Berrangé (2):
>    conf: stop using hash key when free'ing hash entries
>    util: consolidate on one free callback for hash data
> 
>   src/conf/domain_addr.c              |  4 +--
>   src/conf/nwfilter_params.c          |  2 +-
>   src/conf/virchrdev.c                | 43 +++++++++++++++++++----------
>   src/conf/virdomainmomentobjlist.c   |  3 +-
>   src/conf/virnetworkobj.c            |  2 +-
>   src/libxl/libxl_logger.c            |  2 +-
>   src/locking/lock_daemon.c           |  3 +-
>   src/nwfilter/nwfilter_dhcpsnoop.c   |  4 +--
>   src/nwfilter/nwfilter_learnipaddr.c |  2 +-
>   src/qemu/qemu_block.c               |  3 +-
>   src/qemu/qemu_conf.c                |  4 +--
>   src/qemu/qemu_conf.h                |  2 +-
>   src/qemu/qemu_domain.c              |  3 +-
>   src/qemu/qemu_migration.c           |  3 +-
>   src/qemu/qemu_monitor.c             |  5 ++--
>   src/qemu/qemu_monitor.h             |  2 +-
>   src/qemu/qemu_monitor_json.c        |  2 +-
>   src/util/vircgroup.c                |  2 +-
>   src/util/virhash.c                  | 28 +++++--------------
>   src/util/virhash.h                  | 16 ++---------
>   src/util/virjson.c                  |  3 +-
>   src/util/virjson.h                  |  2 +-
>   src/util/virkeyfile.c               |  2 +-
>   src/util/virlockspace.c             |  2 +-
>   src/util/virobject.c                |  3 +-
>   src/util/virobject.h                |  3 +-
>   src/util/virsystemd.c               |  8 +++---
>   27 files changed, 70 insertions(+), 88 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list