On 11/14/19 4:59 PM, Jonathon Jongsma wrote:
> This is the third version of this patch series after a review from Cole. The
> main changes to this version of the patch series are:
> - several patches have been pushed upstream (and therefore dropped from this
> series
> - The iteration over child nodes was moved up to the caller due to a
> suggestion from Cole (much better, thanks)
> - Because the parse functions are now only called when the appropriate XML
> element is present, the parse functions no longer need to return
> "successful" NULL for the case where the element is not specified in the
> XML. Therefore we do not need to change the function signatures and we can
> simply treat a NULL return value as an error.
> - the resolution validation is moved to virDomainVideoDefValidate().
>
> Jonathon Jongsma (4):
> conf: iterate video model children in parent function
> conf: report errors when parsing video resolution
> conf: report errors when parsing video acceleration
> conf: validate video resolution
>
> src/conf/domain_conf.c | 75 ++++++++++++++++++++++--------------------
> 1 file changed, 40 insertions(+), 35 deletions(-)
>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
And pushed
- Cole
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list