Coverity related patches

[libvirt] [PATCH 0/8] Coverity related patches

John Ferlan posted 8 patches 4 years, 5 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191103135340.3505-1-jferlan@redhat.com

src/conf/domain_event.c  | 6 +++++-
src/conf/domain_event.h  | 2 +-
src/lxc/lxc_container.c  | 5 -----
src/qemu/qemu_driver.c   | 2 +-
src/vbox/vbox_common.c   | 4 ++--
tests/qemuagenttest.c    | 4 +++-
tests/qemuhotplugtest.c  | 3 +--
tests/qemuxml2argvmock.c | 2 +-
tests/virbitmaptest.c    | 6 ++++--
9 files changed, 18 insertions(+), 16 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/8] Coverity related patches

Posted by John Ferlan 4 years, 5 months ago

Some related to "new-ish" changes that have caused Coverity to
discover new issues and some from older changes from a pile of
50 or so that are not essentially "false positives".

John Ferlan (8):
  vbox: Fix possible NULL deref
  conf: Remove ATTRIBUTE_NONNULL for virDomainQemuMonitorEventNew
  tests: Fix memory leak in mymain
  lxc: Remove unnecessary comment
  tests: Remove _NULLABLE in virNetDevExists mock
  qemu: Fix possible NULL deref in qemuDomainSaveImageStartVM
  tests: Add return value check in checkUserInfo
  tests: Fix logic to not have possible NULL deref

 src/conf/domain_event.c  | 6 +++++-
 src/conf/domain_event.h  | 2 +-
 src/lxc/lxc_container.c  | 5 -----
 src/qemu/qemu_driver.c   | 2 +-
 src/vbox/vbox_common.c   | 4 ++--
 tests/qemuagenttest.c    | 4 +++-
 tests/qemuhotplugtest.c  | 3 +--
 tests/qemuxml2argvmock.c | 2 +-
 tests/virbitmaptest.c    | 6 ++++--
 9 files changed, 18 insertions(+), 16 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/8] Coverity related patches

Posted by Daniel P. Berrangé 4 years, 5 months ago

On Sun, Nov 03, 2019 at 08:53:32AM -0500, John Ferlan wrote:
> Some related to "new-ish" changes that have caused Coverity to
> discover new issues and some from older changes from a pile of
> 50 or so that are not essentially "false positives".
> 
> John Ferlan (8):
>   vbox: Fix possible NULL deref
>   conf: Remove ATTRIBUTE_NONNULL for virDomainQemuMonitorEventNew
>   tests: Fix memory leak in mymain
>   lxc: Remove unnecessary comment
>   tests: Remove _NULLABLE in virNetDevExists mock
>   qemu: Fix possible NULL deref in qemuDomainSaveImageStartVM
>   tests: Add return value check in checkUserInfo
>   tests: Fix logic to not have possible NULL deref

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list