[libvirt] [PATCH] qemu: fix CPU model error probing capabilities for ppc

Daniel P. Berrangé posted 1 patch 4 years, 6 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191018182239.3460-1-berrange@redhat.com
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] qemu: fix CPU model error probing capabilities for ppc
Posted by Daniel P. Berrangé 4 years, 6 months ago
The CPU driver only supports CPU models for PPC64 architecture, not
plain PPC.

  Failed to probe capabilities for /usr/bin/qemu-system-ppc:
  this function is not supported by the connection driver:
  'ppc' architecture is not supported by CPU driver

This fixes a bug in

  commit db873ab3bc5f6fbd7d227727a62ccfee3d1c3e9d
  Author: Jiri Denemark <jdenemar@redhat.com>
  Date:   Thu May 17 17:08:42 2018 +0200

    qemu: Adapt to changed ppc64 CPU model names

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/qemu/qemu_capabilities.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 3ce1556fc2..03093fd73b 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2454,7 +2454,7 @@ virQEMUCapsFetchCPUDefinitions(qemuMonitorPtr mon,
 
     /* QEMU 2.11 for Power renamed all CPU models to lower case, we need to
      * translate them back to libvirt's upper case model names. */
-    if (ARCH_IS_PPC(arch)) {
+    if (ARCH_IS_PPC64(arch)) {
         VIR_AUTOSTRINGLIST libvirtModels = NULL;
         char **name;
 
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: fix CPU model error probing capabilities for ppc
Posted by Daniel Henrique Barboza 4 years, 6 months ago

On 10/18/19 3:22 PM, Daniel P. Berrangé wrote:
> The CPU driver only supports CPU models for PPC64 architecture, not
> plain PPC.
> 
>    Failed to probe capabilities for /usr/bin/qemu-system-ppc:
>    this function is not supported by the connection driver:
>    'ppc' architecture is not supported by CPU driver
> 
> This fixes a bug in
> 
>    commit db873ab3bc5f6fbd7d227727a62ccfee3d1c3e9d
>    Author: Jiri Denemark <jdenemar@redhat.com>
>    Date:   Thu May 17 17:08:42 2018 +0200
> 
>      qemu: Adapt to changed ppc64 CPU model names
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/qemu/qemu_capabilities.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 3ce1556fc2..03093fd73b 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -2454,7 +2454,7 @@ virQEMUCapsFetchCPUDefinitions(qemuMonitorPtr mon,
>   
>       /* QEMU 2.11 for Power renamed all CPU models to lower case, we need to
>        * translate them back to libvirt's upper case model names. */
> -    if (ARCH_IS_PPC(arch)) {
> +    if (ARCH_IS_PPC64(arch)) {
>           VIR_AUTOSTRINGLIST libvirtModels = NULL;
>           char **name;
>   
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: fix CPU model error probing capabilities for ppc
Posted by Andrea Bolognani 4 years, 6 months ago
On Fri, 2019-10-18 at 19:22 +0100, Daniel P. Berrangé wrote:
> The CPU driver only supports CPU models for PPC64 architecture, not
> plain PPC.
> 
>   Failed to probe capabilities for /usr/bin/qemu-system-ppc:
>   this function is not supported by the connection driver:
>   'ppc' architecture is not supported by CPU driver
> 
> This fixes a bug in
> 
>   commit db873ab3bc5f6fbd7d227727a62ccfee3d1c3e9d
>   Author: Jiri Denemark <jdenemar@redhat.com>
>   Date:   Thu May 17 17:08:42 2018 +0200
> 
>     qemu: Adapt to changed ppc64 CPU model names
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sounds about right.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list