a few cleanups in qemu_hotplug.c

[libvirt] [PATCH v2 0/2] a few cleanups in qemu_hotplug.c

Daniel Henrique Barboza posted 2 patches 4 years, 6 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191017154402.31759-1-danielhb413@gmail.com

src/qemu/qemu_hotplug.c | 72 +++++++++++++++++------------------------
1 file changed, 29 insertions(+), 43 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/2] a few cleanups in qemu_hotplug.c

Posted by Daniel Henrique Barboza 4 years, 6 months ago

There is not much to do regarding cleanup and g_auto* in this
file. Here's a couple of simple fixes I've found.


changes from v1:
- added a new patch to remove unused cleanup labels


v1: https://www.redhat.com/archives/libvir-list/2019-September/msg01463.html

Daniel Henrique Barboza (2):
  qemu_hotplug.c: use g_autoptr() with virConnectPtr
  qemu_process: remove unused cleanup labels

 src/qemu/qemu_hotplug.c | 72 +++++++++++++++++------------------------
 1 file changed, 29 insertions(+), 43 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] a few cleanups in qemu_hotplug.c

Posted by Cole Robinson 4 years, 5 months ago

On 10/17/19 11:44 AM, Daniel Henrique Barboza wrote:
> There is not much to do regarding cleanup and g_auto* in this
> file. Here's a couple of simple fixes I've found.
> 
> 
> changes from v1:
> - added a new patch to remove unused cleanup labels
> 
> 
> v1: https://www.redhat.com/archives/libvir-list/2019-September/msg01463.html
> 
> Daniel Henrique Barboza (2):
>   qemu_hotplug.c: use g_autoptr() with virConnectPtr
>   qemu_process: remove unused cleanup labels
> 
>  src/qemu/qemu_hotplug.c | 72 +++++++++++++++++------------------------
>  1 file changed, 29 insertions(+), 43 deletions(-)
> 

I tweaked the patch subjects, to use 'qemu: hotplug:' prefix, the X.c
format isn't typically used. Patch 2 incorrectly mentioned qemu_process,
so I fixed that too

Reviewed-by: Cole Robinson <crobinso@redhat.com>

and pushed

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list