1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] build: Update .gitignore for build-aux files

John Ferlan posted 1 patch 4 years, 6 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191016125426.32235-1-jferlan@redhat.com
.gitignore | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
[libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by John Ferlan 4 years, 6 months ago 
Recent changes moved some files to build-aux and created at least
one more.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---
 .gitignore | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 85ead5c907..30610a37c9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -43,20 +43,22 @@
 /autom4te.cache
 /build-aux/.gitignore
 /build-aux/compile
+/build-aux/config.guess
+/build-aux/config.sub
 /build-aux/depcomp
+/build-aux/install-sh
+/build-aux/ltmain.sh
 /build-aux/missing
 /build-aux/test-driver
 /build/
 /ci/scratch/
 /confdefs.h
 /config.cache
-/config.guess
 /config.h
 /config.h.in
 /config.log
 /config.rpath
 /config.status
-/config.sub
 /configure
 /configure.lineno
 /conftest.*
@@ -96,7 +98,6 @@
 /libvirt*.pc
 /libvirt.spec
 /ltconfig
-/ltmain.sh
 /m4/*
 /mingw-libvirt.spec
 /mkinstalldirs
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by Daniel P. Berrangé 4 years, 6 months ago 
On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
> Recent changes moved some files to build-aux and created at least
> one more.

Really ? I wasn't aware that we'd moved the files listed in
this change.

> 
> Signed-off-by: John Ferlan <jferlan@redhat.com>
> ---
>  .gitignore | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 85ead5c907..30610a37c9 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -43,20 +43,22 @@
>  /autom4te.cache
>  /build-aux/.gitignore
>  /build-aux/compile
> +/build-aux/config.guess
> +/build-aux/config.sub
>  /build-aux/depcomp
> +/build-aux/install-sh
> +/build-aux/ltmain.sh
>  /build-aux/missing
>  /build-aux/test-driver
>  /build/
>  /ci/scratch/
>  /confdefs.h
>  /config.cache
> -/config.guess
>  /config.h
>  /config.h.in
>  /config.log
>  /config.rpath
>  /config.status
> -/config.sub
>  /configure
>  /configure.lineno
>  /conftest.*
> @@ -96,7 +98,6 @@
>  /libvirt*.pc
>  /libvirt.spec
>  /ltconfig
> -/ltmain.sh
>  /m4/*
>  /mingw-libvirt.spec
>  /mkinstalldirs
> -- 
> 2.20.1
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by John Ferlan 4 years, 6 months ago 

On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
> On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
>> Recent changes moved some files to build-aux and created at least
>> one more.
> 
> Really ? I wasn't aware that we'd moved the files listed in
> this change.
> 

Well that's where they now show up... I dunno. I had to clean my
environment more than once due to recent changes and these files now
show up in the noted/changed locations.  I also use a clean environment
for my coverity builds every day and this is where they show up.

If that's not right, then maybe someone else can figure out why - I was
just going for the "clean" look of/for git status. If I need to change
the commit message that works too. I didn't think too long about it.

John

>>
>> Signed-off-by: John Ferlan <jferlan@redhat.com>
>> ---
>>  .gitignore | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 85ead5c907..30610a37c9 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -43,20 +43,22 @@
>>  /autom4te.cache
>>  /build-aux/.gitignore
>>  /build-aux/compile
>> +/build-aux/config.guess
>> +/build-aux/config.sub
>>  /build-aux/depcomp
>> +/build-aux/install-sh
>> +/build-aux/ltmain.sh
>>  /build-aux/missing
>>  /build-aux/test-driver
>>  /build/
>>  /ci/scratch/
>>  /confdefs.h
>>  /config.cache
>> -/config.guess
>>  /config.h
>>  /config.h.in
>>  /config.log
>>  /config.rpath
>>  /config.status
>> -/config.sub
>>  /configure
>>  /configure.lineno
>>  /conftest.*
>> @@ -96,7 +98,6 @@
>>  /libvirt*.pc
>>  /libvirt.spec
>>  /ltconfig
>> -/ltmain.sh
>>  /m4/*
>>  /mingw-libvirt.spec
>>  /mkinstalldirs
>> -- 
>> 2.20.1
>>
>> --
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list
> 
> Regards,
> Daniel
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by Daniel P. Berrangé 4 years, 6 months ago 
On Wed, Oct 16, 2019 at 10:17:16AM -0400, John Ferlan wrote:
> 
> 
> On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
> > On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
> >> Recent changes moved some files to build-aux and created at least
> >> one more.
> > 
> > Really ? I wasn't aware that we'd moved the files listed in
> > this change.
> > 
> 
> Well that's where they now show up... I dunno. I had to clean my
> environment more than once due to recent changes and these files now
> show up in the noted/changed locations.  I also use a clean environment
> for my coverity builds every day and this is where they show up.

Oh in fact I see them in the same place build-aux, but git is not
reporting them despite not being listed in gitignore.

I wonder if it has some default ignore list its using ?


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by Ján Tomko 4 years, 6 months ago 
On Wed, Oct 16, 2019 at 03:23:41PM +0100, Daniel P. Berrangé wrote:
>On Wed, Oct 16, 2019 at 10:17:16AM -0400, John Ferlan wrote:
>>
>>
>> On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
>> > On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
>> >> Recent changes moved some files to build-aux and created at least
>> >> one more.
>> >
>> > Really ? I wasn't aware that we'd moved the files listed in
>> > this change.
>> >
>>
>> Well that's where they now show up... I dunno. I had to clean my
>> environment more than once due to recent changes and these files now
>> show up in the noted/changed locations.  I also use a clean environment
>> for my coverity builds every day and this is where they show up.
>
>Oh in fact I see them in the same place build-aux, but git is not
>reporting them despite not being listed in gitignore.
>

Note that there is another .gitignore in build-aux that lists the
filenames mentioned in the patch

Jano

>I wonder if it has some default ignore list its using ?
>
>
>Regards,
>Daniel
>-- 
>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by John Ferlan 4 years, 6 months ago 

On 10/16/19 10:52 AM, Ján Tomko wrote:
> On Wed, Oct 16, 2019 at 03:23:41PM +0100, Daniel P. Berrangé wrote:
>> On Wed, Oct 16, 2019 at 10:17:16AM -0400, John Ferlan wrote:
>>>
>>>
>>> On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
>>> > On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
>>> >> Recent changes moved some files to build-aux and created at least
>>> >> one more.
>>> >
>>> > Really ? I wasn't aware that we'd moved the files listed in
>>> > this change.
>>> >
>>>
>>> Well that's where they now show up... I dunno. I had to clean my
>>> environment more than once due to recent changes and these files now
>>> show up in the noted/changed locations.  I also use a clean environment
>>> for my coverity builds every day and this is where they show up.
>>
>> Oh in fact I see them in the same place build-aux, but git is not
>> reporting them despite not being listed in gitignore.
>>
> 
> Note that there is another .gitignore in build-aux that lists the
> filenames mentioned in the patch
> 
> Jano
> 

$ cat build-aux/.gitignore
/config.rpath
/useless-if-before-free
/vc-list-files
$

hmm...

commit 144c06d4ee4cdf9c2035b9912844ab42bcd4dd9a
Author: Eric Blake <eblake@redhat.com>
Date:   Tue Nov 16 12:29:09 2010 -0700

    maint: update to latest gnulib

...

There's an 'interesting' change to build-aux/.gitignore

John

>> I wonder if it has some default ignore list its using ?
>>
>>
>> Regards,
>> Daniel
>> -- 
>> |: https://berrange.com      -o-   
>> https://www.flickr.com/photos/dberrange :|
>> |: https://libvirt.org         -o-           
>> https://fstop138.berrange.com :|
>> |: https://entangle-photo.org    -o-   
>> https://www.instagram.com/dberrange :|
>>
>> -- 
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by Eric Blake 4 years, 6 months ago 
On 10/16/19 9:23 AM, Daniel P. Berrangé wrote:
> On Wed, Oct 16, 2019 at 10:17:16AM -0400, John Ferlan wrote:
>>
>>
>> On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
>>> On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
>>>> Recent changes moved some files to build-aux and created at least
>>>> one more.
>>>
>>> Really ? I wasn't aware that we'd moved the files listed in
>>> this change.
>>>
>>
>> Well that's where they now show up... I dunno. I had to clean my
>> environment more than once due to recent changes and these files now
>> show up in the noted/changed locations.  I also use a clean environment
>> for my coverity builds every day and this is where they show up.
> 
> Oh in fact I see them in the same place build-aux, but git is not
> reporting them despite not being listed in gitignore.
> 
> I wonder if it has some default ignore list its using ?

When using gnulib's bootstrap, gnulib creates or augments .gitignore as 
needed to cover files that it copies in or which autoconf/automake will 
install.  But as we have been moving away from that, we have to pick up 
the slack and ignore the files ourselves.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] build: Update .gitignore for build-aux files
Posted by Daniel P. Berrangé 4 years, 6 months ago 
On Wed, Oct 16, 2019 at 10:10:48AM -0500, Eric Blake wrote:
> On 10/16/19 9:23 AM, Daniel P. Berrangé wrote:
> > On Wed, Oct 16, 2019 at 10:17:16AM -0400, John Ferlan wrote:
> > > 
> > > 
> > > On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
> > > > On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
> > > > > Recent changes moved some files to build-aux and created at least
> > > > > one more.
> > > > 
> > > > Really ? I wasn't aware that we'd moved the files listed in
> > > > this change.
> > > > 
> > > 
> > > Well that's where they now show up... I dunno. I had to clean my
> > > environment more than once due to recent changes and these files now
> > > show up in the noted/changed locations.  I also use a clean environment
> > > for my coverity builds every day and this is where they show up.
> > 
> > Oh in fact I see them in the same place build-aux, but git is not
> > reporting them despite not being listed in gitignore.
> > 
> > I wonder if it has some default ignore list its using ?
> 
> When using gnulib's bootstrap, gnulib creates or augments .gitignore as
> needed to cover files that it copies in or which autoconf/automake will
> install.  But as we have been moving away from that, we have to pick up the
> slack and ignore the files ourselves.

I think we're fine to continue relyuing on bootstrap to create this
.gitignore file until we switch to meson, at which point it won't
matter anyway, as we'll isolate everything gnulib does in its own
subdirectory away from the root.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.