[v1] Fix build with musl libc

[libvirt] [PATCH 0/2] Fix build with musl libc

casantos@redhat.com posted 2 patches 4 years, 6 months ago

Diff against v1
Download series mbox

Test syntax-check passed

Failed in applying to current master (apply log)

src/qemu/qemu_process.c                | 8 ++++----
src/qemu/qemu_process.h                | 2 +-
src/storage/storage_backend_fs.c       | 3 +++
src/storage/storage_backend_vstorage.c | 3 +++
4 files changed, 11 insertions(+), 5 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Fix build with musl libc

Posted by casantos@redhat.com 4 years, 6 months ago

From: Carlos Santos <casantos@redhat.com>

- Do not use 'stderr' as a field name, since it's a preprocessor macro
  in stdio.h.
- Include paths.h for _PATH_MOUNTED, if it's not defined in mntent.h.

Found while porting libvirt to Buildroot (https://buildroot.org/).

Carlos Santos (2):
  qemu: fix build with musl libc
  storage: fix build with musl libc

 src/qemu/qemu_process.c                | 8 ++++----
 src/qemu/qemu_process.h                | 2 +-
 src/storage/storage_backend_fs.c       | 3 +++
 src/storage/storage_backend_vstorage.c | 3 +++
 4 files changed, 11 insertions(+), 5 deletions(-)

-- 
2.18.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Fix build with musl libc

Posted by Michal Privoznik 4 years, 6 months ago

On 10/16/19 1:22 PM, casantos@redhat.com wrote:
> From: Carlos Santos <casantos@redhat.com>
> 
> - Do not use 'stderr' as a field name, since it's a preprocessor macro
>    in stdio.h.
> - Include paths.h for _PATH_MOUNTED, if it's not defined in mntent.h.
> 
> Found while porting libvirt to Buildroot (https://buildroot.org/).
> 
> Carlos Santos (2):
>    qemu: fix build with musl libc
>    storage: fix build with musl libc
> 
>   src/qemu/qemu_process.c                | 8 ++++----
>   src/qemu/qemu_process.h                | 2 +-
>   src/storage/storage_backend_fs.c       | 3 +++
>   src/storage/storage_backend_vstorage.c | 3 +++
>   4 files changed, 11 insertions(+), 5 deletions(-)
> 

I've fixed 2/2 as suggested, and pushed.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Congratulations on your first libvirt contribution!

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list