[v1] use virStringParseYesNo helper

[libvirt] [PATCH 0/3] use virStringParseYesNo helper

Posted by Mao Zhongyi 4 years, 6 months ago

A function virStringParseYesNo was added to convert
string 'yes' to true and 'no' to false, so use this
helper to replace 'STREQ(.*, \"yes\")' and
'STREQ(.*, \"no\")' as it allows us to drop several
repetitive if-then-else string->bool conversion blocks.

Cc: abologna@redhat.com
Cc: berrange@redhat.com
Cc: crobinso@redhat.com
Cc: gene@czarc.net
Cc: g.sho1500@gmail.com
Cc: jdenemar@redhat.com
Cc: laine@laine.org
Cc: mkletzan@redhat.com
Cc: phrdina@redhat.com

Mao Zhongyi (3):
  conf/domain_conf: use virStringParseYesNo helper
  conf/network_conf: use virStringParseYesNo helper
  qemu/qemu_migration_params: use virStringParseYesNo helper

 src/conf/domain_conf.c           | 30 ++++++++++++++----------------
 src/conf/network_conf.c          |  4 +---
 src/qemu/qemu_migration_params.c |  6 +-----
 3 files changed, 16 insertions(+), 24 deletions(-)

-- 
2.17.1



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] use virStringParseYesNo helper

Posted by Andrea Bolognani 4 years, 6 months ago

On Wed, 2019-10-16 at 10:39 +0800, Mao Zhongyi wrote:
> A function virStringParseYesNo was added to convert
> string 'yes' to true and 'no' to false, so use this
> helper to replace 'STREQ(.*, \"yes\")' and
> 'STREQ(.*, \"no\")' as it allows us to drop several
> repetitive if-then-else string->bool conversion blocks.
> 
> Cc: abologna@redhat.com
> Cc: berrange@redhat.com
> Cc: crobinso@redhat.com
> Cc: gene@czarc.net
> Cc: g.sho1500@gmail.com
> Cc: jdenemar@redhat.com
> Cc: laine@laine.org
> Cc: mkletzan@redhat.com
> Cc: phrdina@redhat.com

Please do *not* CC random libvirt developer when sending patches to
the list: we are all subscribed, and someone will get to your patches
eventually; if you haven't gotten any replies after two weeks or so,
then it's perfectly fine to ping but once again do that on the list,
not targeting specific individuals.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] use virStringParseYesNo helper

Posted by maozy 4 years, 6 months ago


On 10/16/19 3:51 PM, Andrea Bolognani wrote:
> On Wed, 2019-10-16 at 10:39 +0800, Mao Zhongyi wrote:
>> A function virStringParseYesNo was added to convert
>> string 'yes' to true and 'no' to false, so use this
>> helper to replace 'STREQ(.*, \"yes\")' and
>> 'STREQ(.*, \"no\")' as it allows us to drop several
>> repetitive if-then-else string->bool conversion blocks.
>>
>> Cc: abologna@redhat.com
>> Cc: berrange@redhat.com
>> Cc: crobinso@redhat.com
>> Cc: gene@czarc.net
>> Cc: g.sho1500@gmail.com
>> Cc: jdenemar@redhat.com
>> Cc: laine@laine.org
>> Cc: mkletzan@redhat.com
>> Cc: phrdina@redhat.com
> 
> Please do *not* CC random libvirt developer when sending patches to
> the list: we are all subscribed, and someone will get to your patches
> eventually; if you haven't gotten any replies after two weeks or so,
> then it's perfectly fine to ping but once again do that on the list,
> not targeting specific individuals.
> 

Ok, I got it, thanks for the clarification.

Thanks,
Mao


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list