[libvirt] [jenkins-ci PATCH v3 11/12] libvirt-dbus: Take advantage of Python 3 on CentOS 7

Fabiano Fidêncio posted 12 patches 5 years, 1 month ago
[libvirt] [jenkins-ci PATCH v3 11/12] libvirt-dbus: Take advantage of Python 3 on CentOS 7
Posted by Fabiano Fidêncio 5 years, 1 month ago
As latest CentOS 7 has added python3, CentOS 7 has support to python3,
let's run syntax-check job the project.

Also, let's update the comment explaining that we don't run `make check`
on CentOS 7 because python3-pytest version is too old.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/build/projects/libvirt-dbus.yml | 10 +++++-----
 jenkins/projects/libvirt-dbus.yaml               | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/guests/playbooks/build/projects/libvirt-dbus.yml b/guests/playbooks/build/projects/libvirt-dbus.yml
index 218bcc1..148be8f 100644
--- a/guests/playbooks/build/projects/libvirt-dbus.yml
+++ b/guests/playbooks/build/projects/libvirt-dbus.yml
@@ -9,10 +9,10 @@
 - include: '{{ playbook_base }}/jobs/autotools-build-job.yml'
 - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
   vars:
-    # CentOS 7 doesn't include Python 3, while the versions of flake8
-    # and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
-    # respectively) are not compatible
+    # flake8 and pyflakes versions currently available on FreeBSD
+    # (3.5.0 and 2.0.0 respectively) are not compatible.
     machines:
+      - libvirt-centos-7
       - libvirt-debian-9
       - libvirt-debian-10
       - libvirt-debian-sid
@@ -23,8 +23,8 @@
       - libvirt-ubuntu-18
 - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
   vars:
-    # CentOS 7 doesn't include Python 3 and the version in Ubuntu
-    # 16.04 is too old
+    # Python3 version in Ubuntu 16.04 and python3-pytest version
+    # in CentOS 7 are too old.
     machines:
       - libvirt-debian-9
       - libvirt-debian-10
diff --git a/jenkins/projects/libvirt-dbus.yaml b/jenkins/projects/libvirt-dbus.yaml
index f7a52ef..b4f5e1e 100644
--- a/jenkins/projects/libvirt-dbus.yaml
+++ b/jenkins/projects/libvirt-dbus.yaml
@@ -10,10 +10,10 @@
           parent_jobs: 'libvirt-glib-build'
       - autotools-syntax-check-job:
           parent_jobs: 'libvirt-dbus-build'
-          # CentOS 7 doesn't include Python 3, while the versions of flake8
-          # and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
-          # respectively) are not compatible
+          # flake8 and pyflakes versions currently available on FreeBSD
+          # (3.5.0 and 2.0.0 respectively) are not compatible.
           machines:
+            - libvirt-centos-7
             - libvirt-debian-9
             - libvirt-debian-10
             - libvirt-fedora-29
@@ -21,8 +21,8 @@
             - libvirt-fedora-rawhide
       - autotools-check-job:
           parent_jobs: 'libvirt-dbus-syntax-check'
-          # CentOS 7 doesn't include Python 3 and the version in Ubuntu
-          # 16.04 is too old
+          # Python 3 version in Ubuntu 16.04 and python3-pytest version
+          # in CentOS 7 are too old.
           machines:
             - libvirt-debian-9
             - libvirt-debian-10
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list