[libvirt] [PATCH v2 0/5] build: take full ownership of syntax-check from gnulib

Daniel P. Berrangé posted 5 patches 1 week ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191008154844.29327-1-berrange@redhat.com
.gitignore                          |    9 +-
GNUmakefile                         |   74 ++
Makefile.am                         |    7 +-
bootstrap.conf                      |    4 -
cfg.mk => build-aux/syntax-check.mk | 1122 +++++++++++++++++++++++++--
build-aux/useless-if-before-free    |  226 ++++++
build-aux/vc-list-files             |  113 +++
configure.ac                        |    6 +
8 files changed, 1482 insertions(+), 79 deletions(-)
create mode 100644 GNUmakefile
rename cfg.mk => build-aux/syntax-check.mk (53%)
create mode 100755 build-aux/useless-if-before-free
create mode 100755 build-aux/vc-list-files

[libvirt] [PATCH v2 0/5] build: take full ownership of syntax-check from gnulib

Posted by Daniel P. Berrangé 1 week ago
Our syntax-check rule relies in various files imported during the gnulib
bootstrap process. As we switch to meson & try to eliminate gnulib, we
need to take ownership of syntax-check.

This patch series follows the approach taken for libosinfo & other
projects wrt syntax-check rules, but goes a step further and eliminates
alot of baggage we don't care about & merges all logic into one file.

Changed in v2:

 - Keep a top level GNUmakefile to preserve the hack
   that forced serialization of build targets

Daniel P. Berrangé (5):
  build: import gnulib's syntax-check make rules
  build: move syntax-check code into build-aux directory
  build: remove all logic unrelated to syntax-check
  build: delete all syntax check rules we're skipping
  build: merge all syntax-check logic into one file

 .gitignore                          |    9 +-
 GNUmakefile                         |   74 ++
 Makefile.am                         |    7 +-
 bootstrap.conf                      |    4 -
 cfg.mk => build-aux/syntax-check.mk | 1122 +++++++++++++++++++++++++--
 build-aux/useless-if-before-free    |  226 ++++++
 build-aux/vc-list-files             |  113 +++
 configure.ac                        |    6 +
 8 files changed, 1482 insertions(+), 79 deletions(-)
 create mode 100644 GNUmakefile
 rename cfg.mk => build-aux/syntax-check.mk (53%)
 create mode 100755 build-aux/useless-if-before-free
 create mode 100755 build-aux/vc-list-files

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/5] build: take full ownership of syntax-check from gnulib

Posted by Michal Privoznik 1 week ago
On 10/8/19 5:48 PM, Daniel P. Berrangé wrote:
> Our syntax-check rule relies in various files imported during the gnulib
> bootstrap process. As we switch to meson & try to eliminate gnulib, we
> need to take ownership of syntax-check.
> 
> This patch series follows the approach taken for libosinfo & other
> projects wrt syntax-check rules, but goes a step further and eliminates
> alot of baggage we don't care about & merges all logic into one file.
> 
> Changed in v2:
> 
>   - Keep a top level GNUmakefile to preserve the hack
>     that forced serialization of build targets

Yep, this helped.

> 
> Daniel P. Berrangé (5):
>    build: import gnulib's syntax-check make rules

syntax-check fails after this one, but I'm not sure it's worth trying to 
fix it. I mean, of course it's failing, because maint.mk is not ignored 
by syntax-check and yet contains examples of prohibited code patterns in 
comments and such. Anyway, it's fixed in 2/5.

>    build: move syntax-check code into build-aux directory
>    build: remove all logic unrelated to syntax-check
>    build: delete all syntax check rules we're skipping
>    build: merge all syntax-check logic into one file
> 
>   .gitignore                          |    9 +-
>   GNUmakefile                         |   74 ++
>   Makefile.am                         |    7 +-
>   bootstrap.conf                      |    4 -
>   cfg.mk => build-aux/syntax-check.mk | 1122 +++++++++++++++++++++++++--
>   build-aux/useless-if-before-free    |  226 ++++++
>   build-aux/vc-list-files             |  113 +++
>   configure.ac                        |    6 +
>   8 files changed, 1482 insertions(+), 79 deletions(-)
>   create mode 100644 GNUmakefile
>   rename cfg.mk => build-aux/syntax-check.mk (53%)
>   create mode 100755 build-aux/useless-if-before-free
>   create mode 100755 build-aux/vc-list-files
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list