build: eliminate many redundant/obsolete gnulib modules

[libvirt] [PATCH 02/11] build: drop the getopt-posix gnulib module

Posted by Daniel P. Berrangé 6 years, 2 months ago

The getopt-posix module fixes a problem with optind being incorrectly
set after a failed option parse. This is not something that matters to
libvirt code.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 bootstrap.conf | 1 -
 po/POTFILES    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 4f944a9c23..22f6153f3c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -51,7 +51,6 @@ fsync
 getaddrinfo
 getcwd-lgpl
 gethostname
-getopt-posix
 getpass
 getpeername
 getsockname
diff --git a/po/POTFILES b/po/POTFILES
index 35fc26c4b9..9385fc4e15 100644
--- a/po/POTFILES
+++ b/po/POTFILES
@@ -1,5 +1,4 @@
 gnulib/lib/gai_strerror.c
-gnulib/lib/getopt.c
 gnulib/lib/regcomp.c
 src/access/viraccessdriverpolkit.c
 src/access/viraccessmanager.c
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/11] build: drop the getopt-posix gnulib module

Posted by Ján Tomko 6 years, 2 months ago

On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
>The getopt-posix module fixes a problem with optind being incorrectly
>set after a failed option parse. This is not something that matters to
>libvirt code.
>

This module was introduced by:

commit b436a8ae5ccb04f8cf893d882d52ab5efc713307
    gnulib: add getopt module

for the patches implementing command line parsing for the bhyve
driver. So you can also remove the gl_REPLACE_GETOPT_ALWAYS definition
in m4/virt-driver-bhyve.m4 and delete gnulib/lib/getopt.c from
POTFILES.in.

>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> bootstrap.conf | 1 -
> po/POTFILES    | 1 -
> 2 files changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/11] build: drop the getopt-posix gnulib module

Posted by Daniel P. Berrangé 6 years, 2 months ago

On Thu, Oct 03, 2019 at 05:12:52PM +0200, Ján Tomko wrote:
> On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
> > The getopt-posix module fixes a problem with optind being incorrectly
> > set after a failed option parse. This is not something that matters to
> > libvirt code.
> > 
> 
> This module was introduced by:
> 
> commit b436a8ae5ccb04f8cf893d882d52ab5efc713307
>    gnulib: add getopt module
> 
> for the patches implementing command line parsing for the bhyve
> driver. So you can also remove the gl_REPLACE_GETOPT_ALWAYS definition
> in m4/virt-driver-bhyve.m4 and delete gnulib/lib/getopt.c from
> POTFILES.in.

POTFILES.in was renamed to POTFILES which I've updated here.

> 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > bootstrap.conf | 1 -
> > po/POTFILES    | 1 -
> > 2 files changed, 2 deletions(-)
> > 
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> Jano



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list