1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info

Fabiano Fidêncio posted 1 patch 4 years, 6 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20191003132840.934553-1-fidencio@redhat.com
src/qemu/qemu_capabilities.c                     | 2 ++
tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml | 1 +
5 files changed, 6 insertions(+)
[libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info
Posted by Fabiano Fidêncio 4 years, 6 months ago 
086c19d69 added bochs-display capability but didn't fill in the info for
domain capabilities.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
 src/qemu/qemu_capabilities.c                     | 2 ++
 tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
 tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1 +
 tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml | 1 +
 tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml | 1 +
 5 files changed, 6 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 3b50576a2b..d0b789bbea 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -5357,6 +5357,8 @@ virQEMUCapsFillDomainDeviceVideoCaps(virQEMUCapsPtr qemuCaps,
         VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_QXL);
     if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU))
         VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_VIRTIO);
+    if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_BOCHS_DISPLAY))
+        VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_BOCHS);
 
     return 0;
 }
diff --git a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
index 402848442f..059403cebc 100644
--- a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
@@ -127,6 +127,7 @@
         <value>vmvga</value>
         <value>qxl</value>
         <value>virtio</value>
+        <value>bochs</value>
       </enum>
     </video>
     <hostdev supported='yes'>
diff --git a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
index 1ffd5e3cc0..eb24b9a604 100644
--- a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
@@ -127,6 +127,7 @@
         <value>vmvga</value>
         <value>qxl</value>
         <value>virtio</value>
+        <value>bochs</value>
       </enum>
     </video>
     <hostdev supported='yes'>
diff --git a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
index 79b41ef6da..f5685d2068 100644
--- a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
@@ -131,6 +131,7 @@
         <value>vmvga</value>
         <value>qxl</value>
         <value>virtio</value>
+        <value>bochs</value>
       </enum>
     </video>
     <hostdev supported='yes'>
diff --git a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
index 6bdeb20479..5bd376bb2e 100644
--- a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
@@ -131,6 +131,7 @@
         <value>vmvga</value>
         <value>qxl</value>
         <value>virtio</value>
+        <value>bochs</value>
       </enum>
     </video>
     <hostdev supported='yes'>
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info
Posted by Daniel Henrique Barboza 4 years, 6 months ago 

On 10/3/19 10:28 AM, Fabiano Fidêncio wrote:
> 086c19d69 added bochs-display capability but didn't fill in the info for
> domain capabilities.
>
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/qemu/qemu_capabilities.c                     | 2 ++
>   tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
>   tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1 +
>   tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml | 1 +
>   tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml | 1 +
>   5 files changed, 6 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 3b50576a2b..d0b789bbea 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -5357,6 +5357,8 @@ virQEMUCapsFillDomainDeviceVideoCaps(virQEMUCapsPtr qemuCaps,
>           VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_QXL);
>       if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU))
>           VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_VIRTIO);
> +    if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_BOCHS_DISPLAY))
> +        VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_BOCHS);
>   
>       return 0;
>   }
> diff --git a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
> index 402848442f..059403cebc 100644
> --- a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
> +++ b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
> @@ -127,6 +127,7 @@
>           <value>vmvga</value>
>           <value>qxl</value>
>           <value>virtio</value>
> +        <value>bochs</value>
>         </enum>
>       </video>
>       <hostdev supported='yes'>
> diff --git a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
> index 1ffd5e3cc0..eb24b9a604 100644
> --- a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
> +++ b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
> @@ -127,6 +127,7 @@
>           <value>vmvga</value>
>           <value>qxl</value>
>           <value>virtio</value>
> +        <value>bochs</value>
>         </enum>
>       </video>
>       <hostdev supported='yes'>
> diff --git a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
> index 79b41ef6da..f5685d2068 100644
> --- a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
> +++ b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
> @@ -131,6 +131,7 @@
>           <value>vmvga</value>
>           <value>qxl</value>
>           <value>virtio</value>
> +        <value>bochs</value>
>         </enum>
>       </video>
>       <hostdev supported='yes'>
> diff --git a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
> index 6bdeb20479..5bd376bb2e 100644
> --- a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
> +++ b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
> @@ -131,6 +131,7 @@
>           <value>vmvga</value>
>           <value>qxl</value>
>           <value>virtio</value>
> +        <value>bochs</value>
>         </enum>
>       </video>
>       <hostdev supported='yes'>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info
Posted by Michal Privoznik 4 years, 6 months ago 
On 10/3/19 3:28 PM, Fabiano Fidêncio wrote:
> 086c19d69 added bochs-display capability but didn't fill in the info for
> domain capabilities.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
>   src/qemu/qemu_capabilities.c                     | 2 ++
>   tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
>   tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1 +
>   tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml | 1 +
>   tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml | 1 +
>   5 files changed, 6 insertions(+)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

And pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info
Posted by Erik Skultety 4 years, 6 months ago 
On Thu, Oct 03, 2019 at 03:28:40PM +0200, Fabiano Fidêncio wrote:
> 086c19d69 added bochs-display capability but didn't fill in the info for
> domain capabilities.
>
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
If the bochs-was added in this release, then I'd say we should put it right in,
but since we're already one release late, I think it can way 1 more :).
Nevertheless:

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.