[libvirt] [PATCH] rpm: stop compressing the ChangeLog file

Daniel P. Berrangé posted 1 patch 4 years, 6 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190923125642.23090-1-berrange@redhat.com
libvirt.spec.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[libvirt] [PATCH] rpm: stop compressing the ChangeLog file
Posted by Daniel P. Berrangé 4 years, 6 months ago
We stopped generating a giant ChangeLog file in

  commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba
  Author: Andrea Bolognani <abologna@redhat.com>
  Date:   Mon Apr 1 17:33:03 2019 +0200

      maint: Stop generating ChangeLog from git

so there is no reason to compress it anymore.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index e2f2a40238..c7448ed6a6 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1225,7 +1225,6 @@ rm -f po/stamp-po
            --with-init-script=systemd \
            %{?arg_login_shell}
 make %{?_smp_mflags} V=1
-gzip -9 ChangeLog
 
 %install
 rm -fr %{buildroot}
@@ -1532,7 +1531,7 @@ exit 0
 %files
 
 %files docs
-%doc AUTHORS ChangeLog.gz NEWS README README.md
+%doc AUTHORS ChangeLog NEWS README README.md
 %doc libvirt-docs/*
 
 %files daemon
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm: stop compressing the ChangeLog file
Posted by Laine Stump 4 years, 6 months ago
On 9/23/19 8:56 AM, Daniel P. Berrangé wrote:
> We stopped generating a giant ChangeLog file in
>
>    commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba
>    Author: Andrea Bolognani <abologna@redhat.com>
>    Date:   Mon Apr 1 17:33:03 2019 +0200
>
>        maint: Stop generating ChangeLog from git
>
> so there is no reason to compress it anymore.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


(I've never liked ChangeLog files anyway...)


Reviewed-by: Laine Stump <laine@laine.org>


> ---
>   libvirt.spec.in | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e2f2a40238..c7448ed6a6 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1225,7 +1225,6 @@ rm -f po/stamp-po
>              --with-init-script=systemd \
>              %{?arg_login_shell}
>   make %{?_smp_mflags} V=1
> -gzip -9 ChangeLog
>   
>   %install
>   rm -fr %{buildroot}
> @@ -1532,7 +1531,7 @@ exit 0
>   %files
>   
>   %files docs
> -%doc AUTHORS ChangeLog.gz NEWS README README.md
> +%doc AUTHORS ChangeLog NEWS README README.md
>   %doc libvirt-docs/*
>   
>   %files daemon


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list