conf: refresh network ports missing from network driver

[libvirt] [PATCH 0/2] conf: refresh network ports missing from network driver

Posted by Laine Stump 4 years, 7 months ago

Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler.

NB: these two patches should also be included with the other patches for 
https://bugzilla.redhat.com/1745815

Laine Stump (2):
  conf: take advantage of VIR_AUTO* in virDomainNetCreatePort()
  conf: refresh network ports missing from network driver on restart

 src/conf/domain_conf.c       | 82 +++++++++++++++++++-----------------
 src/conf/virnetworkportdef.h |  1 +
 2 files changed, 44 insertions(+), 39 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] conf: refresh network ports missing from network driver

Posted by Laine Stump 4 years, 7 months ago

ping

On 9/21/19 7:59 PM, Laine Stump wrote:
> Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler.
>
> NB: these two patches should also be included with the other patches for
> https://bugzilla.redhat.com/1745815
>
> Laine Stump (2):
>    conf: take advantage of VIR_AUTO* in virDomainNetCreatePort()
>    conf: refresh network ports missing from network driver on restart
>
>   src/conf/domain_conf.c       | 82 +++++++++++++++++++-----------------
>   src/conf/virnetworkportdef.h |  1 +
>   2 files changed, 44 insertions(+), 39 deletions(-)
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] conf: refresh network ports missing from network driver

Posted by Michal Privoznik 4 years, 7 months ago

On 9/22/19 1:59 AM, Laine Stump wrote:
> Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler.
> 
> NB: these two patches should also be included with the other patches for
> https://bugzilla.redhat.com/1745815
> 
> Laine Stump (2):
>    conf: take advantage of VIR_AUTO* in virDomainNetCreatePort()
>    conf: refresh network ports missing from network driver on restart
> 
>   src/conf/domain_conf.c       | 82 +++++++++++++++++++-----------------
>   src/conf/virnetworkportdef.h |  1 +
>   2 files changed, 44 insertions(+), 39 deletions(-)
> 


Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

And I don't care if you squash 1.5/2 into 1/2 as you suggest or push it 
as a separate patch. But please address my comments first.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list