[v2] a few cleanups in qemu_domain_address.c

[libvirt] [PATCH v2 0/2] a few cleanups in qemu_domain_address.c

Daniel Henrique Barboza posted 2 patches 4 years, 7 months ago

Diff against v1
Download series mbox

Test syntax-check passed

Failed in applying to current master (apply log)

src/qemu/qemu_domain_address.c | 125 +++++++++++++++------------------
1 file changed, 55 insertions(+), 70 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/2] a few cleanups in qemu_domain_address.c

Posted by Daniel Henrique Barboza 4 years, 7 months ago

Second round of these cleanups after the reviews from
Eric.


changes from v1:
- fixed the commit message of patch 1
- ditched the virPCIAddressSet() approach - use direct
assignment instead


v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00823.html 

Daniel Henrique Barboza (2):
  qemu_domain_address.c: use VIR_AUTOFREE() in strings
  qemu_domain_address: use virPCIDeviceAddressEqual() in conditionals

 src/qemu/qemu_domain_address.c | 125 +++++++++++++++------------------
 1 file changed, 55 insertions(+), 70 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] a few cleanups in qemu_domain_address.c

Posted by Erik Skultety 4 years, 7 months ago

On Fri, Sep 20, 2019 at 10:52:53AM -0300, Daniel Henrique Barboza wrote:
> Second round of these cleanups after the reviews from
> Eric.
>
>
> changes from v1:
> - fixed the commit message of patch 1
> - ditched the virPCIAddressSet() approach - use direct
> assignment instead
>
>
> v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00823.html
>
> Daniel Henrique Barboza (2):
>   qemu_domain_address.c: use VIR_AUTOFREE() in strings
>   qemu_domain_address: use virPCIDeviceAddressEqual() in conditionals
>
>  src/qemu/qemu_domain_address.c | 125 +++++++++++++++------------------
>  1 file changed, 55 insertions(+), 70 deletions(-)

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list