Fix systemd socket activation for systemd < v227

[libvirt] [PATCH 0/2] Fix systemd socket activation for systemd < v227

Michael Chapman posted 2 patches 4 years, 7 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190917070357.4424-1-mike@very.puzzling.org

src/remote/remote_daemon.c | 2 +-
src/util/virsocketaddr.c   | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] Fix systemd socket activation for systemd < v227

Posted by Michael Chapman 4 years, 7 months ago

A couple of bugs were encountered using socket activated libvirtd on
CentOS 7:

- When resolving a tls_port/tcp_port from the config file (needed even
  when using socket activation on systemd < v227), the port endianness
  was incorrect.

- The wrong name was used when checking whether libvirtd-tls.socket
  was passed to libvirtd, leading to this socket not being properly
  registered.

Michael Chapman (2):
  util: fix byte order of port in virSocketAddrResolveService
  remote: fix registration of TLS socket

 src/remote/remote_daemon.c | 2 +-
 src/util/virsocketaddr.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Fix systemd socket activation for systemd < v227

Posted by Daniel P. Berrangé 4 years, 7 months ago

On Tue, Sep 17, 2019 at 05:03:55PM +1000, Michael Chapman wrote:
> A couple of bugs were encountered using socket activated libvirtd on
> CentOS 7:

It actually hits on new distros too

> - When resolving a tls_port/tcp_port from the config file (needed even
>   when using socket activation on systemd < v227), the port endianness
>   was incorrect.

Opps.

> - The wrong name was used when checking whether libvirtd-tls.socket
>   was passed to libvirtd, leading to this socket not being properly
>   registered.

Due to the refactoring for the split daemons being messed up.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list