[libvirt] [PATCH] virsh: Fix help for net-port-delete

Jonathon Jongsma posted 1 patch 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190903164729.4971-1-jjongsma@redhat.com
tools/virsh-network.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

[libvirt] [PATCH] virsh: Fix help for net-port-delete

Posted by Jonathon Jongsma 2 weeks ago
Apparently a copy/paste error. The net-port-delete help string was in
fact from net-port-dumpxml.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1747826

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
---
 tools/virsh-network.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index af08441842..be16f7970e 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.c
@@ -1593,10 +1593,10 @@ cmdNetworkPortDumpXML(vshControl *ctl, const vshCmd *cmd)
  */
 static const vshCmdInfo info_network_port_delete[] = {
     {.name = "help",
-     .data = N_("network port information in XML")
+     .data = N_("delete the specified network port")
     },
     {.name = "desc",
-     .data = N_("Output the network port information as an XML dump to stdout.")
+     .data = N_("Delete the specified network port.")
     },
     {.name = NULL}
 };
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: Fix help for net-port-delete

Posted by Laine Stump 2 weeks ago
On 9/3/19 12:47 PM, Jonathon Jongsma wrote:
> Apparently a copy/paste error. The net-port-delete help string was in
> fact from net-port-dumpxml.
>
> Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1747826
>
> Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
> ---
>   tools/virsh-network.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virsh-network.c b/tools/virsh-network.c
> index af08441842..be16f7970e 100644
> --- a/tools/virsh-network.c
> +++ b/tools/virsh-network.c
> @@ -1593,10 +1593,10 @@ cmdNetworkPortDumpXML(vshControl *ctl, const vshCmd *cmd)
>    */
>   static const vshCmdInfo info_network_port_delete[] = {
>       {.name = "help",
> -     .data = N_("network port information in XML")
> +     .data = N_("delete the specified network port")
>       },
>       {.name = "desc",
> -     .data = N_("Output the network port information as an XML dump to stdout.")
> +     .data = N_("Delete the specified network port.")
>       },
>       {.name = NULL}
>   };


Reviewed-by: Laine Stump <laine@laine.org>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list