libvirt-ocaml: add a simple check job

[libvirt] [jenkins-ci PATCH v2] libvirt-ocaml: add a simple check job

Posted by Pino Toscano 4 years, 7 months ago

Run 'make check-manifest' as build step, so we ensure that the MANIFEST
file is up-to-date, and thus dist will (hopefully) work.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
---

Changes from v1:
- run 'make check-manifest' as separate job

 guests/playbooks/build/projects/libvirt-ocaml.yml | 4 ++++
 jenkins/projects/libvirt-ocaml.yaml               | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml b/guests/playbooks/build/projects/libvirt-ocaml.yml
index 7a2e216..58f017b 100644
--- a/guests/playbooks/build/projects/libvirt-ocaml.yml
+++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
@@ -25,3 +25,7 @@
       ./configure --prefix=$VIRT_PREFIX
       $MAKE
       $MAKE opt
+- include: '{{ playbook_base }}/jobs/generic-check-job.yml'
+  vars:
+    command: |
+      $MAKE check-manifest
diff --git a/jenkins/projects/libvirt-ocaml.yaml b/jenkins/projects/libvirt-ocaml.yaml
index 8eb03e3..0c819cc 100644
--- a/jenkins/projects/libvirt-ocaml.yaml
+++ b/jenkins/projects/libvirt-ocaml.yaml
@@ -21,3 +21,7 @@
             ./configure --prefix=$VIRT_PREFIX
             $MAKE
             $MAKE opt
+      - generic-check-job:
+          parent_jobs: 'libvirt-ocaml-build'
+          command: |
+            $MAKE check-manifest
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH v2] libvirt-ocaml: add a simple check job

Posted by Andrea Bolognani 4 years, 7 months ago

On Tue, 2019-09-03 at 15:18 +0200, Pino Toscano wrote:
> Run 'make check-manifest' as build step, so we ensure that the MANIFEST
> file is up-to-date, and thus dist will (hopefully) work.
> 
> Signed-off-by: Pino Toscano <ptoscano@redhat.com>
> ---
> 
> Changes from v1:
> - run 'make check-manifest' as separate job
> 
>  guests/playbooks/build/projects/libvirt-ocaml.yml | 4 ++++
>  jenkins/projects/libvirt-ocaml.yaml               | 4 ++++
>  2 files changed, 8 insertions(+)

Better! :)

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed as well as applied:

  https://ci.centos.org/view/libvirt/job/libvirt-ocaml-check/

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list