[libvirt] [PATCH] news: document new libxml version requirement

Daniel P. Berrangé posted 1 patch 2 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190903122444.24454-1-berrange@redhat.com
docs/news.xml | 9 +++++++++
1 file changed, 9 insertions(+)

[libvirt] [PATCH] news: document new libxml version requirement

Posted by Daniel P. Berrangé 2 weeks ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/news.xml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 92d566c2fe..434aeab933 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -63,6 +63,15 @@
           KVM device assignment from libvirt too.
         </description>
       </change>
+      <change>
+        <summary>
+          libxml: min required libxml is now 2.9.1
+        </summary>
+        <description>
+          Support for building with libxml versions older than 2.9.1
+          has been dropped.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: document new libxml version requirement

Posted by Andrea Bolognani 2 weeks ago
On Tue, 2019-09-03 at 13:24 +0100, Daniel P. Berrangé wrote:
> +      <change>
> +        <summary>
> +          libxml: min required libxml is now 2.9.1
> +        </summary>
> +        <description>
> +          Support for building with libxml versions older than 2.9.1
> +          has been dropped.
> +        </description>
> +      </change>

I don't think we need to document this in the release notes: for
starters, configure will already complain loudly if libxml on the
host is too old, same as it does for any other dependency, and
additionally the version bump is fully in line with our established
platform support policy.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: document new libxml version requirement

Posted by Daniel P. Berrangé 2 weeks ago
On Tue, Sep 03, 2019 at 04:19:01PM +0200, Andrea Bolognani wrote:
> On Tue, 2019-09-03 at 13:24 +0100, Daniel P. Berrangé wrote:
> > +      <change>
> > +        <summary>
> > +          libxml: min required libxml is now 2.9.1
> > +        </summary>
> > +        <description>
> > +          Support for building with libxml versions older than 2.9.1
> > +          has been dropped.
> > +        </description>
> > +      </change>
> 
> I don't think we need to document this in the release notes: for
> starters, configure will already complain loudly if libxml on the
> host is too old, same as it does for any other dependency, and
> additionally the version bump is fully in line with our established
> platform support policy.

I don't agree. This is something I expect to be prominent in any
application's release notes or news. There's no downside to giving
users this information upfront.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: document new libxml version requirement

Posted by Andrea Bolognani 2 weeks ago
On Tue, 2019-09-03 at 15:22 +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 03, 2019 at 04:19:01PM +0200, Andrea Bolognani wrote:
> > On Tue, 2019-09-03 at 13:24 +0100, Daniel P. Berrangé wrote:
> > > +      <change>
> > > +        <summary>
> > > +          libxml: min required libxml is now 2.9.1
> > > +        </summary>
> > > +        <description>
> > > +          Support for building with libxml versions older than 2.9.1
> > > +          has been dropped.
> > > +        </description>
> > > +      </change>
> > 
> > I don't think we need to document this in the release notes: for
> > starters, configure will already complain loudly if libxml on the
> > host is too old, same as it does for any other dependency, and
> > additionally the version bump is fully in line with our established
> > platform support policy.
> 
> I don't agree. This is something I expect to be prominent in any
> application's release notes or news. There's no downside to giving
> users this information upfront.

We have traditionally not done this but alright, I can see how it
could be helpful in some scenarios.

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and safe for freeze.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list