support use of precreated tap devices from unprivileged libvirtd

[libvirt] [PATCH 9/9] docs: update news file

Posted by Laine Stump 6 years, 3 months ago

with info about support for using precreated tap/macvtap devices in
unprivileged libvirtd.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 docs/news.xml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index c6580e4e72..be51d6c953 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -50,6 +50,19 @@
           for Hyper-V guests.
         </description>
       </change>
+      <change>
+        <summary>
+          qemu: Support use of precreated tap/macvtap devices by unprivileged libvirtd
+        </summary>
+        <description>
+          It is now possible for an unprivileged libvirtd to make use
+          of tap and macvtap devices that were previously created by
+          some other entity. Since is done by setting
+          <code>managed='no'</code> along with the device name in the
+          <code>target</code> subelement of <code>&lt;interface
+          type='ethernet'&gt;</code>
+        </description>
+      </change>
     </section>
     <section title="Removed features">
       <change>
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 9/9] docs: update news file

Posted by Andrea Bolognani 6 years, 1 month ago

On Tue, 2019-08-27 at 21:46 -0400, Laine Stump wrote:
> with info about support for using precreated tap/macvtap devices in
> unprivileged libvirtd.
> 
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
>  docs/news.xml | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

You mentioned this was never reviewed, so here we go :)

> +      <change>
> +        <summary>
> +          qemu: Support use of precreated tap/macvtap devices by unprivileged libvirtd
> +        </summary>
> +        <description>
> +          It is now possible for an unprivileged libvirtd to make use
> +          of tap and macvtap devices that were previously created by
> +          some other entity. Since is done by setting

s/Since/This/

> +          <code>managed='no'</code> along with the device name in the
> +          <code>target</code> subelement of <code>&lt;interface
> +          type='ethernet'&gt;</code>

The description should end with a period.


With the above fixed, and the patch updated so that it actually
applies,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list