At this moment, the unplug timeout Libvirt uses is 5
seconds. Which is good enough for most cases, but can
be troublesome for cases in which it is not enough. For
example, PowerPC guests with lots of vcpus can experience
the 'vcpu unplug request timed out' message depending on the
guest workload. What happens is that the user doesn't know
if there was a problem in the unplug operation in QEMU, or
the process took a bit longer than 5 seconds and Libvirt
timed out, with QEMU carrying on the unplug operation
regardless.

This series implements a new 'unplug_timeout' attribute
to allow the user to set this parameter, allowing users
to set bigger timeouts, if so they choose. The existing
5 seconds timeout is the default value if the attribute
isn't set. 5 seconds is also the minimal timeout
allowed. 

Daniel Henrique Barboza (3):
  adding unplug_timeout QEMU conf
  qemu_hotplug: use qemu_driver->unplugTimeout in device removal
  qemu: Remove qemu_hotplugpriv.h

 src/qemu/Makefile.inc.am           |  1 -
 src/qemu/libvirtd_qemu.aug         |  3 +++
 src/qemu/qemu.conf                 |  4 ++++
 src/qemu/qemu_conf.c               | 26 ++++++++++++++++++++++++
 src/qemu/qemu_conf.h               |  5 +++++
 src/qemu/qemu_driver.c             |  2 ++
 src/qemu/qemu_hotplug.c            | 15 +++++---------
 src/qemu/qemu_hotplugpriv.h        | 32 ------------------------------
 src/qemu/test_libvirtd_qemu.aug.in |  1 +
 tests/qemuhotplugtest.c            |  3 +--
 10 files changed, 47 insertions(+), 45 deletions(-)
 delete mode 100644 src/qemu/qemu_hotplugpriv.h

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list