[libvirt] [PATCH] src: Don't check lxc_monitor_protocol-struct when LXC is disabled

Michal Privoznik posted 1 patch 13 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190814131328.117999-1-mprivozn@redhat.com
src/Makefile.am | 2 ++
1 file changed, 2 insertions(+)

[libvirt] [PATCH] src: Don't check lxc_monitor_protocol-struct when LXC is disabled

Posted by Michal Privoznik 13 weeks ago
If LXC is disabled at build time then there is no
libvirt_driver_lxc_impl_la-*.lo to run the 'check-protocol'
against.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/Makefile.am b/src/Makefile.am
index 3ae4b87abb..817a7ecf34 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -318,9 +318,11 @@ $(srcdir)/remote_protocol-struct \
 $(srcdir)/virnetprotocol-struct $(srcdir)/virkeepaliveprotocol-struct: \
 		$(srcdir)/%-struct: rpc/libvirt_net_rpc_la-%.lo
 	$(PDWTAGS)
+if WITH_LXC
 $(srcdir)/lxc_monitor_protocol-struct: \
 		$(srcdir)/%-struct: lxc/libvirt_driver_lxc_impl_la-%.lo
 	$(PDWTAGS)
+endif WITH_LXC
 $(srcdir)/lock_protocol-struct: \
 		$(srcdir)/%-struct: locking/lockd_la-%.lo
 	$(PDWTAGS)
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: Don't check lxc_monitor_protocol-struct when LXC is disabled

Posted by Daniel Henrique Barboza 12 weeks ago

On 8/14/19 10:13 AM, Michal Privoznik wrote:
> If LXC is disabled at build time then there is no
> libvirt_driver_lxc_impl_la-*.lo to run the 'check-protocol'
> against.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/Makefile.am | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 3ae4b87abb..817a7ecf34 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -318,9 +318,11 @@ $(srcdir)/remote_protocol-struct \
>   $(srcdir)/virnetprotocol-struct $(srcdir)/virkeepaliveprotocol-struct: \
>   		$(srcdir)/%-struct: rpc/libvirt_net_rpc_la-%.lo
>   	$(PDWTAGS)
> +if WITH_LXC
>   $(srcdir)/lxc_monitor_protocol-struct: \
>   		$(srcdir)/%-struct: lxc/libvirt_driver_lxc_impl_la-%.lo
>   	$(PDWTAGS)
> +endif WITH_LXC
>   $(srcdir)/lock_protocol-struct: \
>   		$(srcdir)/%-struct: locking/lockd_la-%.lo
>   	$(PDWTAGS)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list