[libvirt] [PATCH] ci: Adapt to container name changes

Andrea Bolognani posted 1 patch 5 days ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190812140901.4977-1-abologna@redhat.com
Makefile.ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] ci: Adapt to container name changes

Posted by Andrea Bolognani 5 days ago
Since libvirt-dockerfile's commit 7130ffe0a0e9, the containers
used for CI builds have been renamed from buildenv-* to
buildenv-libvirt-* in order to make it possible for projects
other than libvirt to be supported, so we need to update our
Makefile.ci scaffolding accordingly.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
This is connected to

  https://www.redhat.com/archives/libvir-list/2019-August/msg00399.html
  https://www.redhat.com/archives/libvir-list/2019-August/msg00416.html

and should only be merged once the above have been merged *and*
deployed, as in, images with the new names have been generated.

 Makefile.ci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.ci b/Makefile.ci
index 8857c953b2..dddd438a98 100644
--- a/Makefile.ci
+++ b/Makefile.ci
@@ -49,7 +49,7 @@ CI_SUBMODULES = $(shell git submodule | awk '{ print $$2 }')
 # Location of the container images we're going to pull
 # Can be useful to overridde to use a locally built
 # image instead
-CI_IMAGE_PREFIX = quay.io/libvirt/buildenv-
+CI_IMAGE_PREFIX = quay.io/libvirt/buildenv-libvirt-
 
 # The default tag is ':latest' but if the container
 # repo above uses different conventions this can override it
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] ci: Adapt to container name changes

Posted by Fabiano Fidêncio 1 day ago
On Mon, 2019-08-12 at 16:09 +0200, Andrea Bolognani wrote:
> Since libvirt-dockerfile's commit 7130ffe0a0e9, the containers
> used for CI builds have been renamed from buildenv-* to
> buildenv-libvirt-* in order to make it possible for projects
> other than libvirt to be supported, so we need to update our
> Makefile.ci scaffolding accordingly.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> This is connected to
> 
>   
> https://www.redhat.com/archives/libvir-list/2019-August/msg00399.html
>   
> https://www.redhat.com/archives/libvir-list/2019-August/msg00416.html
> 
> and should only be merged once the above have been merged *and*
> deployed, as in, images with the new names have been generated.
> 
>  Makefile.ci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.ci b/Makefile.ci
> index 8857c953b2..dddd438a98 100644
> --- a/Makefile.ci
> +++ b/Makefile.ci
> @@ -49,7 +49,7 @@ CI_SUBMODULES = $(shell git submodule | awk '{
> print $$2 }')
>  # Location of the container images we're going to pull
>  # Can be useful to overridde to use a locally built
>  # image instead
> -CI_IMAGE_PREFIX = quay.io/libvirt/buildenv-
> +CI_IMAGE_PREFIX = quay.io/libvirt/buildenv-libvirt-
>  
>  # The default tag is ':latest' but if the container
>  # repo above uses different conventions this can override it

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] ci: Adapt to container name changes

Posted by Andrea Bolognani 1 day ago
On Fri, 2019-08-16 at 14:32 +0200, Fabiano Fidêncio wrote:
> On Mon, 2019-08-12 at 16:09 +0200, Andrea Bolognani wrote:
> > This is connected to
> > 
> > https://www.redhat.com/archives/libvir-list/2019-August/msg00399.html
> > 
> > https://www.redhat.com/archives/libvir-list/2019-August/msg00416.html
> > 
> > and should only be merged once the above have been merged *and*
> > deployed, as in, images with the new names have been generated.
> 
> Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

Thanks for the reviews!

I have pushed the other two series but I can't quite push this one
yet because, as we already know, a bunch of MinGW packages have been
dropped from Fedora and thus the buildenv-libvirt-fedora-rawhide
container can't currently be built successfully:

  No match for argument: mingw32-portablexdr
  No match for argument: mingw64-portablexdr
  Error: Unable to find a match: mingw32-portablexdr mingw64-portablexdr

I think the situation would be the same for the libosinfo container.

Do you have any idea how long it will take to get the packages back
in Fedora? Should we just wait for that to happen before rebuilding
the containers, temporarily disable MinGW builds, temporarily switch
MinGW builds to Fedora 30 where I assume all MinGW packages are still
available?

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] ci: Adapt to container name changes

Posted by Fabiano Fidêncio 1 day ago
On Fri, 2019-08-16 at 15:51 +0200, Andrea Bolognani wrote:
> On Fri, 2019-08-16 at 14:32 +0200, Fabiano Fidêncio wrote:
> > On Mon, 2019-08-12 at 16:09 +0200, Andrea Bolognani wrote:
> > > This is connected to
> > > 
> > > https://www.redhat.com/archives/libvir-list/2019-August/msg00399.html
> > > 
> > > https://www.redhat.com/archives/libvir-list/2019-August/msg00416.html
> > > 
> > > and should only be merged once the above have been merged *and*
> > > deployed, as in, images with the new names have been generated.
> > 
> > Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
> 
> Thanks for the reviews!
> 
> I have pushed the other two series but I can't quite push this one
> yet because, as we already know, a bunch of MinGW packages have been
> dropped from Fedora and thus the buildenv-libvirt-fedora-rawhide
> container can't currently be built successfully:
> 
>   No match for argument: mingw32-portablexdr
>   No match for argument: mingw64-portablexdr
>   Error: Unable to find a match: mingw32-portablexdr mingw64-
> portablexdr
> 
> I think the situation would be the same for the libosinfo container.
> 
> Do you have any idea how long it will take to get the packages back
> in Fedora?

We're working on it.
For mingw-portablexdr we may end up not adding it back and adding
mingw-libtirpc.

For mingw-libsoup (which is the piece missing from libosinfo side),
we've already asked to un-retire the package.

Bugs are still open though.

> Should we just wait for that to happen before rebuilding
> the containers, temporarily disable MinGW builds, temporarily switch
> MinGW builds to Fedora 30 where I assume all MinGW packages are still
> available?

I'd go for this solution, stick to Fedora 30, at least till the
situation is back to stable on rawhide.

I'll provide you some patches for this and regenerate the images.

Best Regards,
-- 
Fabiano Fidêncio

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list