conf: code comment fix for TPM version

[libvirt] [PATCH] conf: code comment fix for TPM version

Posted by marcandre.lureau@redhat.com 4 years, 8 months ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Since its introduction in commit
8737578d115b8328f59f3342377b0c7ac06f658a, the TPM version format is
"2.0" and not "2".

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 src/conf/domain_conf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0456369d55..e4c280e0d5 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13053,13 +13053,13 @@ virDomainSmartcardDefParseXML(virDomainXMLOptionPtr xmlopt,
  * or like this:
  *
  * <tpm model='tpm-tis'>
- *   <backend type='emulator' version='2'/>
+ *   <backend type='emulator' version='2.0'/>
  * </tpm>
  *
  * Emulator state encryption is supported with the following:
  *
  * <tpm model='tpm-tis'>
- *   <backend type='emulator' version='2'>
+ *   <backend type='emulator' version='2.0'>
  *     <encryption uuid='32ee7e76-2178-47a1-ab7b-269e6e348015'/>
  *   </backend>
  * </tpm>
-- 
2.23.0.rc1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: code comment fix for TPM version

Posted by Michal Privoznik 4 years, 8 months ago

On 8/9/19 2:23 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Since its introduction in commit
> 8737578d115b8328f59f3342377b0c7ac06f658a, the TPM version format is
> "2.0" and not "2".
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   src/conf/domain_conf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

And pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: code comment fix for TPM version

Posted by Erik Skultety 4 years, 8 months ago

On Fri, Aug 09, 2019 at 04:23:48PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Since its introduction in commit
> 8737578d115b8328f59f3342377b0c7ac06f658a, the TPM version format is
> "2.0" and not "2".
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
The html docs agrees with that:
Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list