admin: Fix missing filters of debug msg for virAdmConnectSetLoggingFilters

[libvirt] [PATCH] admin: Fix missing filters of debug msg for virAdmConnectSetLoggingFilters

Han Han posted 1 patch 4 years, 8 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190809062941.2091-1-hhan@redhat.com

src/libvirt-admin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] admin: Fix missing filters of debug msg for virAdmConnectSetLoggingFilters

Posted by Han Han 4 years, 8 months ago

Signed-off-by: Han Han <hhan@redhat.com>
---
 src/libvirt-admin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c
index 4ae50b188f..cf40ea122e 100644
--- a/src/libvirt-admin.c
+++ b/src/libvirt-admin.c
@@ -1236,7 +1236,7 @@ virAdmConnectSetLoggingFilters(virAdmConnectPtr conn,
 {
     int ret = -1;
 
-    VIR_DEBUG("conn=%p, flags=0x%x", conn, flags);
+    VIR_DEBUG("conn=%p, filters=%s, flags=0x%x", conn, filters, flags);
 
     virResetLastError();
     virCheckAdmConnectReturn(conn, -1);
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] admin: Fix missing filters of debug msg for virAdmConnectSetLoggingFilters

Posted by Michal Privoznik 4 years, 8 months ago

On 8/9/19 8:29 AM, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>   src/libvirt-admin.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Ah, good catch. There are some other APIs that don't log all the 
arguments. I'm adding them into this patch, changing the commit message 
a big, ACKing and pushing.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list