[v2] Use a slirp helper process

[libvirt] [PATCH v2 02/23] tests: fix xml2xml tpm-emulator.xml test

Posted by marcandre.lureau@redhat.com 6 years, 6 months ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

It is failing, because it ends up being parsed with version='default'
and expects '1.2' instead.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/qemuxml2argvdata/tpm-emulator.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemuxml2argvdata/tpm-emulator.xml b/tests/qemuxml2argvdata/tpm-emulator.xml
index 7f1e5756cb..defc3789ad 100644
--- a/tests/qemuxml2argvdata/tpm-emulator.xml
+++ b/tests/qemuxml2argvdata/tpm-emulator.xml
@@ -23,7 +23,7 @@
     <input type='mouse' bus='ps2'/>
     <input type='keyboard' bus='ps2'/>
     <tpm model='tpm-tis'>
-      <backend type='emulator'/>
+      <backend type='emulator' version='1.2'/>
     </tpm>
     <memballoon model='virtio'/>
   </devices>
-- 
2.23.0.rc1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 02/23] tests: fix xml2xml tpm-emulator.xml test

Posted by Michal Privoznik 6 years, 5 months ago

On 8/8/19 4:54 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> It is failing, because it ends up being parsed with version='default'
> and expects '1.2' instead.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   tests/qemuxml2argvdata/tpm-emulator.xml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list