From: Julio Faracco <jcfaracco@gmail.com>

This serie adds 'xres' and 'yres' properties into XML definition for QXL
video device to specify a default resolution. This serie covers a simple
test case too.

Julio Faracco (4):
  docs: Adding 'xres' and 'yres' into qxl XML definition
  conf: Adding XML support for 'xres' and 'yres'
  qemu: Generate 'xres' and 'yres' for qxl device.
  tests: Add separate tests for 'xres' and 'yres'

 docs/schemas/domaincommon.rng                 | 10 +++++
 src/conf/domain_conf.c                        | 26 ++++++++++++
 src/conf/domain_conf.h                        |  2 +
 src/qemu/qemu_command.c                       |  4 ++
 .../video-qxl-resolution.args                 | 32 +++++++++++++++
 .../qemuxml2argvdata/video-qxl-resolution.xml | 40 +++++++++++++++++++
 tests/qemuxml2argvtest.c                      |  4 ++
 .../video-qxl-resolution.xml                  | 40 +++++++++++++++++++
 tests/qemuxml2xmltest.c                       |  1 +
 9 files changed, 159 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/video-qxl-resolution.args
 create mode 100644 tests/qemuxml2argvdata/video-qxl-resolution.xml
 create mode 100644 tests/qemuxml2xmloutdata/video-qxl-resolution.xml

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfaracco@gmail.com wrote:
> From: Julio Faracco <jcfaracco@gmail.com>
> 
> This serie adds 'xres' and 'yres' properties into XML definition for QXL
> video device to specify a default resolution. This serie covers a simple
> test case too.

Why limit this to qxl?

virtio and stdvga support xres+yres too.

Note: on stdvga this requires edid support (available since 3.1, enabled
by default since 4.1).

cheers,
  Gerd

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Aug 05, 2019 at 09:12:26AM +0200, Gerd Hoffmann wrote:
> On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfaracco@gmail.com wrote:
> > From: Julio Faracco <jcfaracco@gmail.com>
> >
> > This serie adds 'xres' and 'yres' properties into XML definition for QXL
> > video device to specify a default resolution. This serie covers a simple
> > test case too.
>
> Why limit this to qxl?
>
> virtio and stdvga support xres+yres too.
>
> Note: on stdvga this requires edid support (available since 3.1, enabled
> by default since 4.1).

Gerd, I'd already responded by the time you had a look, so just to confirm that
I'd looked at the schema properly, it isn't possible to query support for this
from QAPI, is it?

Regards,
Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Aug 05, 2019 at 11:17:35AM +0200, Erik Skultety wrote:
> On Mon, Aug 05, 2019 at 09:12:26AM +0200, Gerd Hoffmann wrote:
> > On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfaracco@gmail.com wrote:
> > > From: Julio Faracco <jcfaracco@gmail.com>
> > >
> > > This serie adds 'xres' and 'yres' properties into XML definition for QXL
> > > video device to specify a default resolution. This serie covers a simple
> > > test case too.
> >
> > Why limit this to qxl?
> >
> > virtio and stdvga support xres+yres too.
> >
> > Note: on stdvga this requires edid support (available since 3.1, enabled
> > by default since 4.1).
> 
> Gerd, I'd already responded by the time you had a look, so just to confirm that
> I'd looked at the schema properly, it isn't possible to query support for this
> from QAPI, is it?

You can check this using "qemu -device VGA,help".  I'm not sure whenever
there is a QAPI version of that.

cheers,
  Gerd

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list