[libvirt] [PATCH] daemon: improve Xen support in systemd service

Jim Fehlig posted 1 patch 4 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190731181744.7073-1-jfehlig@suse.com
Test syntax-check passed
src/remote/libvirtd.service.in | 2 ++
1 file changed, 2 insertions(+)
[libvirt] [PATCH] daemon: improve Xen support in systemd service
Posted by Jim Fehlig 4 years, 8 months ago
The xencommons service provides all the essential services such as
xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so
libvirtd should be started after xencommons.

The xendomains service uses Xen's xl tool to operate on any domains it
finds running, even those managed by libvirt. Add a conflicts on the
xendomains service to ensure it is not enabled when libvirtd is enabled.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 src/remote/libvirtd.service.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
index 3ddf0e229b..5dbe7cbe72 100644
--- a/src/remote/libvirtd.service.in
+++ b/src/remote/libvirtd.service.in
@@ -15,6 +15,8 @@ After=local-fs.target
 After=remote-fs.target
 After=systemd-logind.service
 After=systemd-machined.service
+After=xencommons.service
+Conflicts=xendomains.service
 Documentation=man:libvirtd(8)
 Documentation=https://libvirt.org
 
-- 
2.22.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] daemon: improve Xen support in systemd service
Posted by Daniel P. Berrangé 4 years, 8 months ago
On Wed, Jul 31, 2019 at 06:18:00PM +0000, Jim Fehlig wrote:
> The xencommons service provides all the essential services such as
> xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so
> libvirtd should be started after xencommons.
> 
> The xendomains service uses Xen's xl tool to operate on any domains it
> finds running, even those managed by libvirt. Add a conflicts on the
> xendomains service to ensure it is not enabled when libvirtd is enabled.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
>  src/remote/libvirtd.service.in | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] daemon: improve Xen support in systemd service
Posted by Jim Fehlig 4 years, 8 months ago
On 8/1/19 3:36 AM, Daniel P. Berrangé  wrote:
> On Wed, Jul 31, 2019 at 06:18:00PM +0000, Jim Fehlig wrote:
>> The xencommons service provides all the essential services such as
>> xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so
>> libvirtd should be started after xencommons.
>>
>> The xendomains service uses Xen's xl tool to operate on any domains it
>> finds running, even those managed by libvirt. Add a conflicts on the
>> xendomains service to ensure it is not enabled when libvirtd is enabled.
>>
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>> ---
>>   src/remote/libvirtd.service.in | 2 ++
>>   1 file changed, 2 insertions(+)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

I've pushed this now that the release is out.

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list