News for snapshot validation and vtpm encryption

[libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

Posted by Han Han 6 years, 6 months ago

Signed-off-by: Han Han <hhan@redhat.com>
---
 docs/news.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 1134309ec2..6d90ea8389 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -76,6 +76,16 @@
       </change>
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          qemu: Allow to validate xml for snapshot creation
+        </summary>
+        <description>
+          Add flag <code>VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE</code> to validate
+          snapshot input xml. For virsh, users can use it as <code>virsh
+          snapshot-create --validate</code>.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
     </section>
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

Posted by Andrea Bolognani 6 years, 6 months ago

On Wed, 2019-07-31 at 11:57 +0800, Han Han wrote:
> +        <summary>
> +          qemu: Allow to validate xml for snapshot creation
> +        </summary>
> +        <description>
> +          Add flag <code>VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE</code> to validate
> +          snapshot input xml. For virsh, users can use it as <code>virsh
> +          snapshot-create --validate</code>.
> +        </description>

s/xml/XML/g

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

Posted by Eric Blake 6 years, 6 months ago

On 7/30/19 10:57 PM, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  docs/news.xml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 1134309ec2..6d90ea8389 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -76,6 +76,16 @@
>        </change>
>      </section>
>      <section title="Improvements">
> +      <change>
> +        <summary>
> +          qemu: Allow to validate xml for snapshot creation

"allow to $verb" is not idiomatic English; it is either "allow $subject
to $verb" or "allow ${verb}ing".

In this case, I'd even prefer "Allow validation of xml"

ACK; I can fix that up and push (and thanks for catching that I added
this feature without news).

> +        </summary>
> +        <description>
> +          Add flag <code>VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE</code> to validate
> +          snapshot input xml. For virsh, users can use it as <code>virsh
> +          snapshot-create --validate</code>.
> +        </description>
> +      </change>
>      </section>
>      <section title="Bug fixes">
>      </section>
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list