It's been introduced as dependency as part of v1.6.0 release.
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
guests/vars/projects/libosinfo+mingw32.yml | 1 +
guests/vars/projects/libosinfo+mingw64.yml | 1 +
2 files changed, 2 insertions(+)
diff --git a/guests/vars/projects/libosinfo+mingw32.yml b/guests/vars/projects/libosinfo+mingw32.yml
index 9435d1f..4c90d27 100644
--- a/guests/vars/projects/libosinfo+mingw32.yml
+++ b/guests/vars/projects/libosinfo+mingw32.yml
@@ -2,6 +2,7 @@
packages:
- mingw32-curl
- mingw32-glib2
+ - mingw32-libsoup
- mingw32-libxml2
- mingw32-libxslt
- wget
diff --git a/guests/vars/projects/libosinfo+mingw64.yml b/guests/vars/projects/libosinfo+mingw64.yml
index b71664e..25965e7 100644
--- a/guests/vars/projects/libosinfo+mingw64.yml
+++ b/guests/vars/projects/libosinfo+mingw64.yml
@@ -2,6 +2,7 @@
packages:
- mingw64-curl
- mingw64-glib2
+ - mingw64-libsoup
- mingw64-libxml2
- mingw64-libxslt
- wget
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-listOn Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> It's been introduced as dependency as part of v1.6.0 release.
Is that so? Because the native build has had the dependency on
libsoup ever since
commit 1eab5a66eb0abd922a67e2c96a4c46efce525548
Author: Andrea Bolognani <abologna@redhat.com>
Date: Tue Oct 3 18:11:38 2017 +0200
ansible: Add libosinfo project
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
eg. the day it was introduced. So it seems to me we just messed
up when in
commit c74dcf2ea8787c7e6256cb7cee315dbf2148e799
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: Tue May 8 14:36:22 2018 +0100
Build libosinfo and osinfo-db-tools on mingw platform
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
we didn't include it among the dependencies for the MinGW build,
and we only managed to get away with it so far because it gets
dragged in by mingw*-libgovirt, required for virt-viewer+mingw*.
The change itself is correct, though :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > It's been introduced as dependency as part of v1.6.0 release.
>
> Is that so? Because the native build has had the dependency on
> libsoup ever since
>
> commit 1eab5a66eb0abd922a67e2c96a4c46efce525548
> Author: Andrea Bolognani <abologna@redhat.com>
> Date: Tue Oct 3 18:11:38 2017 +0200
>
> ansible: Add libosinfo project
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>
> eg. the day it was introduced. So it seems to me we just messed
> up when in
Old tests on libosinfo were relying on libsoup and that's the reason I
do believe the dependency was there.
Pino dropped the dependency a long time ago here:
```
commit b61be0405f678986ac344f414fa907af24670488
Author: Pino Toscano <ptoscano@redhat.com>
AuthorDate: Mon Aug 7 18:18:34 2017 +0200
Commit: Christophe Fergeau <cfergeau@redhat.com>
CommitDate: Mon Oct 16 11:12:22 2017 +0200
Switch from libsoup to libcurl
libsoup is used to check the validity of URLs in distributions in
osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to
that protocol.
To overcome this limitation, switch to libcurl: while it requires
slightly more code to do the same task, it provides a bit more
flexibility, and support for other protocols. No version check is
performed, since the APIs used are old enough.
Adapt also the README, and the packaging files.
```
However, libvirt-jenkins-ci was never updated.
[snip]
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, 2019-07-31 at 14:24 +0200, Fabiano Fidêncio wrote: > On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani <abologna@redhat.com> wrote: > > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote: > > > It's been introduced as dependency as part of v1.6.0 release. > > > > Is that so? Because the native build has had the dependency on > > libsoup ever since > > > > commit 1eab5a66eb0abd922a67e2c96a4c46efce525548 > > Author: Andrea Bolognani <abologna@redhat.com> > > Date: Tue Oct 3 18:11:38 2017 +0200 > > > > ansible: Add libosinfo project > > > > Signed-off-by: Andrea Bolognani <abologna@redhat.com> > > > > eg. the day it was introduced. So it seems to me we just messed > > up when in > > Old tests on libosinfo were relying on libsoup and that's the reason I > do believe the dependency was there. > Pino dropped the dependency a long time ago here: > > ``` > commit b61be0405f678986ac344f414fa907af24670488 > Author: Pino Toscano <ptoscano@redhat.com> > AuthorDate: Mon Aug 7 18:18:34 2017 +0200 > Commit: Christophe Fergeau <cfergeau@redhat.com> > CommitDate: Mon Oct 16 11:12:22 2017 +0200 > > Switch from libsoup to libcurl > > libsoup is used to check the validity of URLs in distributions in > osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to > that protocol. > > To overcome this limitation, switch to libcurl: while it requires > slightly more code to do the same task, it provides a bit more > flexibility, and support for other protocols. No version check is > performed, since the APIs used are old enough. > > Adapt also the README, and the packaging files. > ``` > However, libvirt-jenkins-ci was never updated. Alright, I'll keep your commit message as is but I'll add The native build already depended on libsoup because it was never updated after libosinfo switched its test suite from libsoup to libcurl back in 2017. and then push the series. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jul 31, 2019 at 2:37 PM Andrea Bolognani <abologna@redhat.com> wrote: > > On Wed, 2019-07-31 at 14:24 +0200, Fabiano Fidêncio wrote: > > On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani <abologna@redhat.com> wrote: > > > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote: > > > > It's been introduced as dependency as part of v1.6.0 release. > > > > > > Is that so? Because the native build has had the dependency on > > > libsoup ever since > > > > > > commit 1eab5a66eb0abd922a67e2c96a4c46efce525548 > > > Author: Andrea Bolognani <abologna@redhat.com> > > > Date: Tue Oct 3 18:11:38 2017 +0200 > > > > > > ansible: Add libosinfo project > > > > > > Signed-off-by: Andrea Bolognani <abologna@redhat.com> > > > > > > eg. the day it was introduced. So it seems to me we just messed > > > up when in > > > > Old tests on libosinfo were relying on libsoup and that's the reason I > > do believe the dependency was there. > > Pino dropped the dependency a long time ago here: > > > > ``` > > commit b61be0405f678986ac344f414fa907af24670488 > > Author: Pino Toscano <ptoscano@redhat.com> > > AuthorDate: Mon Aug 7 18:18:34 2017 +0200 > > Commit: Christophe Fergeau <cfergeau@redhat.com> > > CommitDate: Mon Oct 16 11:12:22 2017 +0200 > > > > Switch from libsoup to libcurl > > > > libsoup is used to check the validity of URLs in distributions in > > osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to > > that protocol. > > > > To overcome this limitation, switch to libcurl: while it requires > > slightly more code to do the same task, it provides a bit more > > flexibility, and support for other protocols. No version check is > > performed, since the APIs used are old enough. > > > > Adapt also the README, and the packaging files. > > ``` > > However, libvirt-jenkins-ci was never updated. > > Alright, I'll keep your commit message as is but I'll add > > The native build already depended on libsoup because it was never > updated after libosinfo switched its test suite from libsoup to > libcurl back in 2017. > > and then push the series. Ack! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2026 Red Hat, Inc.