[libvirt] [PATCH v2 1/2] tests: virsh-optparse: remove no longer valid cpu-stats test cases

Ilias Stamatis posted 2 patches 6 years, 6 months ago
[libvirt] [PATCH v2 1/2] tests: virsh-optparse: remove no longer valid cpu-stats test cases
Posted by Ilias Stamatis 6 years, 6 months ago
These test cases are no longer valid since this series provides an
implementation of the virDomainGetCPUStats API for the test driver.

Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
---
 tests/virsh-optparse | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/tests/virsh-optparse b/tests/virsh-optparse
index 090d6c205c..d9c8f3c731 100755
--- a/tests/virsh-optparse
+++ b/tests/virsh-optparse
@@ -179,26 +179,6 @@ virsh -q -c $test_url cpu-stats test --start -1 >out 2>err && fail=1
 test -s out && fail=1
 compare exp-err err || fail=1

-# Zero. The test driver doesn't support the operation so the command
-# fails, but the value has been parsed correctly
-cat <<\EOF > exp-err || framework_failure
-error: Failed to retrieve CPU statistics for domain 'test'
-error: this function is not supported by the connection driver: virDomainGetCPUStats
-EOF
-virsh -q -c $test_url cpu-stats test --start 0 >out 2>err && fail=1
-test -s out && fail=1
-compare exp-err err || fail=1
-
-# Valid numeric value. The test driver doesn't support the operation
-# so the command fails, but the value has been parsed correctly
-cat <<\EOF > exp-err || framework_failure
-error: Failed to retrieve CPU statistics for domain 'test'
-error: this function is not supported by the connection driver: virDomainGetCPUStats
-EOF
-virsh -q -c $test_url cpu-stats test --start 42 >out 2>err && fail=1
-test -s out && fail=1
-compare exp-err err || fail=1
-
 ### Test a scaled numeric option

 # Non-numeric value
--
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 1/2] tests: virsh-optparse: remove no longer valid cpu-stats test cases
Posted by Erik Skultety 6 years, 6 months ago
On Sun, Jul 28, 2019 at 12:02:20PM +0200, Ilias Stamatis wrote:
> These test cases are no longer valid since this series provides an
> implementation of the virDomainGetCPUStats API for the test driver.

"this series" is relevant only in context of the patches sent to the ML. Once
it's in the git history, it's essentially irrelevant information. I'll change
it before pushing.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list