qemu: Introduce support for ARM CPU features

[libvirt] [PATCH RFC 00/11] qemu: Introduce support for ARM CPU features

Posted by Andrea Bolognani 4 years, 8 months ago

This series is RFC because the corresponding QEMU patches[1] have
not been merged yet, and since QEMU is currently in the middle of
the 4.1.0 freeze we can't really expect to merge them until 5.7.0
anyway.

With that in mind, a few patches are somewhat independent of the
rest and could, after some minor tweaking, could go in even right
now: 1/11 is really a no brainer, and 3/11 - 5/11 are also fairly
reasonable candidates for that treatment.


[1] https://lists.nongnu.org/archive/html/qemu-devel/2019-06/msg04945.html

Andrea Bolognani (11):
  tests: Update replies for QEMU 2.12.0 on aarch64
  tests: Add replies for QEMU 4.1.0 on aarch64
  qemu: Rename virQEMUCapsObjectPropsMaxX86CPU
  qemu: Introduce QEMU_CAPS_ARM_MAX_CPU
  qemu: Query max-arm-cpu properties
  qemu: Update query-cpu-model-expansion check
  qemu: Perform full expansion on ARM
  cpu_map: Introduce ARM CPU features
  cpu: Validate ARM CPU features
  tests: Introduce tests for ARM CPU features
  news: Update for ARM CPU features

 docs/news.xml                                 |    9 +
 src/cpu/cpu_arm.c                             |  171 ++
 src/cpu_map/arm_features.xml                  |   21 +
 src/cpu_map/index.xml                         |    4 +
 src/qemu/qemu_capabilities.c                  |   18 +-
 src/qemu/qemu_capabilities.h                  |    1 +
 src/qemu/qemu_command.c                       |    3 +-
 .../caps_2.12.0.aarch64.replies               |  324 ++-
 .../caps_2.12.0.aarch64.xml                   |    5 +-
 .../caps_4.0.0.aarch64.replies                |  159 +-
 .../caps_4.0.0.aarch64.xml                    |    1 +
 ...h64.replies => caps_4.1.0.aarch64.replies} | 2205 ++++++++++-------
 ...0.0.aarch64.xml => caps_4.1.0.aarch64.xml} |   53 +-
 .../aarch64-features-sve.aarch64-latest.args  |   32 +
 .../qemuxml2argvdata/aarch64-features-sve.xml |   20 +
 .../aarch64-features-wrong.xml                |   17 +
 tests/qemuxml2argvtest.c                      |    7 +
 17 files changed, 2085 insertions(+), 965 deletions(-)
 create mode 100644 src/cpu_map/arm_features.xml
 copy tests/qemucapabilitiesdata/{caps_4.0.0.aarch64.replies => caps_4.1.0.aarch64.replies} (96%)
 copy tests/qemucapabilitiesdata/{caps_4.0.0.aarch64.xml => caps_4.1.0.aarch64.xml} (80%)
 create mode 100644 tests/qemuxml2argvdata/aarch64-features-sve.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/aarch64-features-sve.xml
 create mode 100644 tests/qemuxml2argvdata/aarch64-features-wrong.xml

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 00/11] qemu: Introduce support for ARM CPU features

Posted by Michal Privoznik 4 years, 8 months ago

On 7/25/19 4:06 PM, Andrea Bolognani wrote:
> This series is RFC because the corresponding QEMU patches[1] have
> not been merged yet, and since QEMU is currently in the middle of
> the 4.1.0 freeze we can't really expect to merge them until 5.7.0
> anyway.
> 
> With that in mind, a few patches are somewhat independent of the
> rest and could, after some minor tweaking, could go in even right
> now: 1/11 is really a no brainer, and 3/11 - 5/11 are also fairly
> reasonable candidates for that treatment.
> 
> 
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2019-06/msg04945.html
> 
> Andrea Bolognani (11):
>    tests: Update replies for QEMU 2.12.0 on aarch64
>    tests: Add replies for QEMU 4.1.0 on aarch64
>    qemu: Rename virQEMUCapsObjectPropsMaxX86CPU
>    qemu: Introduce QEMU_CAPS_ARM_MAX_CPU
>    qemu: Query max-arm-cpu properties
>    qemu: Update query-cpu-model-expansion check
>    qemu: Perform full expansion on ARM
>    cpu_map: Introduce ARM CPU features
>    cpu: Validate ARM CPU features
>    tests: Introduce tests for ARM CPU features
>    news: Update for ARM CPU features
> 
>   docs/news.xml                                 |    9 +
>   src/cpu/cpu_arm.c                             |  171 ++
>   src/cpu_map/arm_features.xml                  |   21 +
>   src/cpu_map/index.xml                         |    4 +
>   src/qemu/qemu_capabilities.c                  |   18 +-
>   src/qemu/qemu_capabilities.h                  |    1 +
>   src/qemu/qemu_command.c                       |    3 +-
>   .../caps_2.12.0.aarch64.replies               |  324 ++-
>   .../caps_2.12.0.aarch64.xml                   |    5 +-
>   .../caps_4.0.0.aarch64.replies                |  159 +-
>   .../caps_4.0.0.aarch64.xml                    |    1 +
>   ...h64.replies => caps_4.1.0.aarch64.replies} | 2205 ++++++++++-------
>   ...0.0.aarch64.xml => caps_4.1.0.aarch64.xml} |   53 +-
>   .../aarch64-features-sve.aarch64-latest.args  |   32 +
>   .../qemuxml2argvdata/aarch64-features-sve.xml |   20 +
>   .../aarch64-features-wrong.xml                |   17 +
>   tests/qemuxml2argvtest.c                      |    7 +
>   17 files changed, 2085 insertions(+), 965 deletions(-)
>   create mode 100644 src/cpu_map/arm_features.xml
>   copy tests/qemucapabilitiesdata/{caps_4.0.0.aarch64.replies => caps_4.1.0.aarch64.replies} (96%)
>   copy tests/qemucapabilitiesdata/{caps_4.0.0.aarch64.xml => caps_4.1.0.aarch64.xml} (80%)
>   create mode 100644 tests/qemuxml2argvdata/aarch64-features-sve.aarch64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/aarch64-features-sve.xml
>   create mode 100644 tests/qemuxml2argvdata/aarch64-features-wrong.xml
> 

Once qemu part is pushed in you can count on my

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 00/11] qemu: Introduce support for ARM CPU features

Posted by Andrea Bolognani 4 years, 8 months ago

On Mon, 2019-08-12 at 16:04 +0200, Michal Privoznik wrote:
> On 7/25/19 4:06 PM, Andrea Bolognani wrote:
> > This series is RFC because the corresponding QEMU patches[1] have
> > not been merged yet, and since QEMU is currently in the middle of
> > the 4.1.0 freeze we can't really expect to merge them until 5.7.0
> > anyway.
> > 
> > With that in mind, a few patches are somewhat independent of the
> > rest and could, after some minor tweaking, could go in even right
> > now: 1/11 is really a no brainer, and 3/11 - 5/11 are also fairly
> > reasonable candidates for that treatment.
> > 
> > 
> > [1] https://lists.nongnu.org/archive/html/qemu-devel/2019-06/msg04945.html
> > 
> > Andrea Bolognani (11):
> >    tests: Update replies for QEMU 2.12.0 on aarch64
> >    tests: Add replies for QEMU 4.1.0 on aarch64
> >    qemu: Rename virQEMUCapsObjectPropsMaxX86CPU
> >    qemu: Introduce QEMU_CAPS_ARM_MAX_CPU
> >    qemu: Query max-arm-cpu properties
> >    qemu: Update query-cpu-model-expansion check
> >    qemu: Perform full expansion on ARM
> >    cpu_map: Introduce ARM CPU features
> >    cpu: Validate ARM CPU features
> >    tests: Introduce tests for ARM CPU features
> >    news: Update for ARM CPU features
> 
> Once qemu part is pushed in you can count on my
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Thanks! :)

I'm gonna push 1/11 right away as it doesn't depend on the QEMU
part at all.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 00/11] qemu: Introduce support for ARM CPU features

Posted by Andrea Bolognani 4 years, 5 months ago

On Mon, 2019-08-12 at 16:04 +0200, Michal Privoznik wrote:
> On 7/25/19 4:06 PM, Andrea Bolognani wrote:
> > Andrea Bolognani (11):
> >    tests: Update replies for QEMU 2.12.0 on aarch64
> >    tests: Add replies for QEMU 4.1.0 on aarch64
> >    qemu: Rename virQEMUCapsObjectPropsMaxX86CPU
> >    qemu: Introduce QEMU_CAPS_ARM_MAX_CPU
> >    qemu: Query max-arm-cpu properties
> >    qemu: Update query-cpu-model-expansion check
> >    qemu: Perform full expansion on ARM
> >    cpu_map: Introduce ARM CPU features
> >    cpu: Validate ARM CPU features
> >    tests: Introduce tests for ARM CPU features
> >    news: Update for ARM CPU features
> 
> Once qemu part is pushed in you can count on my
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

So, the QEMU part ended up taking longer than expected and only
landed a few days ago, so it's going to show up in 4.2.0 instead of
the expected 4.1.0; additionally, through testing Drew and I have
found a few areas where the behavior could be improved.

As a result, [v1] is in some areas different enough from the version
you ACKed that it would not have been appropriate for me to just go
ahead and push it. (On the other hand, a bunch of commits are
basically unchanged and I could have included your R-b when posting,
my bad!)

Would you mind taking a look at the refreshed version? I have
included a reasonably detailed summary of the changes below: the
tl;dr is that only two of the eleven patches will require more than
a cursory look, so hopefully that's not too much bother.

Thanks in advance! :)

   new | old | changes
  ----- ----- -------------------------------------------------
     - |   1 | pushed
     1 |   2 | capabilities are for QEMU 4.2.0 instead of 4.1.0
     2 |   3 | trivial conversion to GLib APIs
     3 |   4 | -
     4 |   5 | trivial conversion to GLib APIs
     5 |   6 | -
     6 |   7 | -
     7 |   8 | added the 'sve' feature
     8 |   9 | significant changes due to GLib adoption
     9 |   - | entirely new patch
    10 |  10 | more testing, specifically for the 'sve' feature
    11 |  11 | -

[v1] https://www.redhat.com/archives/libvir-list/2019-November/msg00127.html
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 00/11] qemu: Introduce support for ARM CPU features

Posted by Andrea Bolognani 4 years, 8 months ago

On Thu, 2019-07-25 at 16:06 +0200, Andrea Bolognani wrote:
> This series is RFC because the corresponding QEMU patches[1] have
> not been merged yet, and since QEMU is currently in the middle of
> the 4.1.0 freeze we can't really expect to merge them until 5.7.0
> anyway.
> 
> With that in mind, a few patches are somewhat independent of the
> rest and could, after some minor tweaking, could go in even right
> now: 1/11 is really a no brainer, and 3/11 - 5/11 are also fairly
> reasonable candidates for that treatment.

Ping?

QEMU patches are still not merged upstream, but I'd like to get at
least 1/11 out of the way earlier than that; I'm open to posting
that one (plus maybe 3/11 - 5/11) separately if desired.

And I'd also like some thoughts on whether the rest of the series
is going in the right direction...

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list