add support for bochs-video device

[libvirt] [PATCH v3 0/2] add support for bochs-video device

Jonathon Jongsma posted 2 patches 4 years, 9 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190712201216.20443-1-jjongsma@redhat.com

docs/formatdomain.html.in                     |  5 ++-
docs/schemas/domaincommon.rng                 |  1 +
src/conf/domain_conf.c                        |  4 ++
src/conf/domain_conf.h                        |  1 +
src/qemu/qemu_capabilities.c                  |  4 ++
src/qemu/qemu_capabilities.h                  |  3 ++
src/qemu/qemu_command.c                       |  6 +++
src/qemu/qemu_domain.c                        |  1 +
src/qemu/qemu_domain_address.c                |  3 ++
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
.../caps_3.0.0.x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
.../caps_3.1.0.x86_64.xml                     |  1 +
.../caps_4.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
.../caps_4.0.0.riscv32.xml                    |  1 +
.../caps_4.0.0.riscv64.xml                    |  1 +
.../caps_4.0.0.x86_64.xml                     |  1 +
.../caps_4.1.0.x86_64.xml                     |  1 +
...eo-bochs-display-device.x86_64-latest.args | 38 +++++++++++++++++++
.../video-bochs-display-device.xml            | 29 ++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
22 files changed, 104 insertions(+), 2 deletions(-)
create mode 100644 tests/qemuxml2argvdata/video-bochs-display-device.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/video-bochs-display-device.xml

Expand all Fold all

[libvirt] [PATCH v3 0/2] add support for bochs-video device

Posted by Jonathon Jongsma 4 years, 9 months ago

Changes from v2:
 - fix version number in documentation
 - move bochs to its own case in virDomainVideoDefaultRAM()
 - use pcieFlags instead of pciFlags in
   qemuDomainDeviceCalculatePCIConnectFlags()
 - use DO_TEST_CAPS_LATEST() in test

Jonathon Jongsma (2):
  qemu: Add bochs-display capability
  qemu: add 'bochs' video display type

 docs/formatdomain.html.in                     |  5 ++-
 docs/schemas/domaincommon.rng                 |  1 +
 src/conf/domain_conf.c                        |  4 ++
 src/conf/domain_conf.h                        |  1 +
 src/qemu/qemu_capabilities.c                  |  4 ++
 src/qemu/qemu_capabilities.h                  |  3 ++
 src/qemu/qemu_command.c                       |  6 +++
 src/qemu/qemu_domain.c                        |  1 +
 src/qemu/qemu_domain_address.c                |  3 ++
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
 .../caps_3.0.0.x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
 .../caps_3.1.0.x86_64.xml                     |  1 +
 .../caps_4.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
 .../caps_4.0.0.riscv32.xml                    |  1 +
 .../caps_4.0.0.riscv64.xml                    |  1 +
 .../caps_4.0.0.x86_64.xml                     |  1 +
 .../caps_4.1.0.x86_64.xml                     |  1 +
 ...eo-bochs-display-device.x86_64-latest.args | 38 +++++++++++++++++++
 .../video-bochs-display-device.xml            | 29 ++++++++++++++
 tests/qemuxml2argvtest.c                      |  1 +
 22 files changed, 104 insertions(+), 2 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/video-bochs-display-device.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/video-bochs-display-device.xml

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/2] add support for bochs-video device

Posted by Andrea Bolognani 4 years, 9 months ago

On Fri, 2019-07-12 at 15:12 -0500, Jonathon Jongsma wrote:
> Changes from v2:
>  - fix version number in documentation
>  - move bochs to its own case in virDomainVideoDefaultRAM()
>  - use pcieFlags instead of pciFlags in
>    qemuDomainDeviceCalculatePCIConnectFlags()
>  - use DO_TEST_CAPS_LATEST() in test
> 
> Jonathon Jongsma (2):
>   qemu: Add bochs-display capability
>   qemu: add 'bochs' video display type

Can you please update the release notes (docs/news.xml) to mention
this new feature? Thanks!

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/2] add support for bochs-video device

Posted by Ján Tomko 4 years, 9 months ago

On Fri, Jul 12, 2019 at 03:12:14PM -0500, Jonathon Jongsma wrote:
>Changes from v2:
> - fix version number in documentation
> - move bochs to its own case in virDomainVideoDefaultRAM()
> - use pcieFlags instead of pciFlags in
>   qemuDomainDeviceCalculatePCIConnectFlags()
> - use DO_TEST_CAPS_LATEST() in test
>
>Jonathon Jongsma (2):
>  qemu: Add bochs-display capability
>  qemu: add 'bochs' video display type
>
> docs/formatdomain.html.in                     |  5 ++-
> docs/schemas/domaincommon.rng                 |  1 +
> src/conf/domain_conf.c                        |  4 ++
> src/conf/domain_conf.h                        |  1 +
> src/qemu/qemu_capabilities.c                  |  4 ++
> src/qemu/qemu_capabilities.h                  |  3 ++
> src/qemu/qemu_command.c                       |  6 +++
> src/qemu/qemu_domain.c                        |  1 +
> src/qemu/qemu_domain_address.c                |  3 ++
> .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
> .../caps_3.0.0.x86_64.xml                     |  1 +
> .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
> .../caps_3.1.0.x86_64.xml                     |  1 +
> .../caps_4.0.0.aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
> .../caps_4.0.0.riscv32.xml                    |  1 +
> .../caps_4.0.0.riscv64.xml                    |  1 +
> .../caps_4.0.0.x86_64.xml                     |  1 +
> .../caps_4.1.0.x86_64.xml                     |  1 +
> ...eo-bochs-display-device.x86_64-latest.args | 38 +++++++++++++++++++
> .../video-bochs-display-device.xml            | 29 ++++++++++++++
> tests/qemuxml2argvtest.c                      |  1 +
> 22 files changed, 104 insertions(+), 2 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/video-bochs-display-device.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/video-bochs-display-device.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>
and pushed.

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list