[libvirt] [libvirt-php PATCH 0/2] Add binding for virDomainInterfaceAddresses

Dawid Zamirski posted 2 patches 1 week ago
Failed in applying to current master (apply log)
src/libvirt-domain.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
src/libvirt-domain.h |  2 ++
src/libvirt-php.c    |  9 ++++++++
src/util.h           |  7 +++---
4 files changed, 70 insertions(+), 3 deletions(-)

[libvirt] [libvirt-php PATCH 0/2] Add binding for virDomainInterfaceAddresses

Posted by Dawid Zamirski 1 week ago
Hello,

The following two patches add a new bingding for virDomainInterfaceAddresses.
While working on it I have found that the PHP7 version of the
VIRT_ARRAY_INIT macro was causing segfaults which I have fixed in the
first patch wheread the actual implementation of the binding is in the
second one. Details are included in the commit messages of each patch.

Regards,
Dawid

Dawid Zamirski (2):
  Fix PHP7 VIRT_ARRAY_INIT macro implementation.
  Add binding for virDomainInterfaceAddresses.

 src/libvirt-domain.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
 src/libvirt-domain.h |  2 ++
 src/libvirt-php.c    |  9 ++++++++
 src/util.h           |  7 +++---
 4 files changed, 70 insertions(+), 3 deletions(-)

-- 
2.21.0


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php PATCH 0/2] Add binding for virDomainInterfaceAddresses

Posted by Michal Privoznik 6 days ago
On 7/8/19 11:32 PM, Dawid Zamirski wrote:
> Hello,
> 
> The following two patches add a new bingding for virDomainInterfaceAddresses.
> While working on it I have found that the PHP7 version of the
> VIRT_ARRAY_INIT macro was causing segfaults which I have fixed in the
> first patch wheread the actual implementation of the binding is in the
> second one. Details are included in the commit messages of each patch.
> 
> Regards,
> Dawid
> 
> Dawid Zamirski (2):
>    Fix PHP7 VIRT_ARRAY_INIT macro implementation.
>    Add binding for virDomainInterfaceAddresses.
> 
>   src/libvirt-domain.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
>   src/libvirt-domain.h |  2 ++
>   src/libvirt-php.c    |  9 ++++++++
>   src/util.h           |  7 +++---
>   4 files changed, 70 insertions(+), 3 deletions(-)
> 


Patches look good, but I cannot push them because they are missing your 
signoff. I can fix it, but I need your permisson to add the following at 
the end of both messages:

   Signed-off-by: Dawid Zamirski <dzamirski@datto.com>

This confirms also that you've agreed to Developer Certificate of Origin 
1.1:

   https://libvirt.org/hacking.html

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php PATCH 0/2] Add binding for virDomainInterfaceAddresses

Posted by Dawid Zamirski 5 days ago
Hi Michal,

Yes, please feel free to add:

Signed-off-by: Dawid Zamirski <dzamirski@datto.com>

to both messages. I'll make sure it is included in my future
submissions from now on.

Thanks,
Dawid

On Fri, 2019-07-12 at 17:12 +0200, Michal Privoznik wrote:
> On 7/8/19 11:32 PM, Dawid Zamirski wrote:
> > Hello,
> > 
> > The following two patches add a new bingding for
> > virDomainInterfaceAddresses.
> > While working on it I have found that the PHP7 version of the
> > VIRT_ARRAY_INIT macro was causing segfaults which I have fixed in
> > the
> > first patch wheread the actual implementation of the binding is in
> > the
> > second one. Details are included in the commit messages of each
> > patch.
> > 
> > Regards,
> > Dawid
> > 
> > Dawid Zamirski (2):
> >    Fix PHP7 VIRT_ARRAY_INIT macro implementation.
> >    Add binding for virDomainInterfaceAddresses.
> > 
> >   src/libvirt-domain.c | 55
> > ++++++++++++++++++++++++++++++++++++++++++++
> >   src/libvirt-domain.h |  2 ++
> >   src/libvirt-php.c    |  9 ++++++++
> >   src/util.h           |  7 +++---
> >   4 files changed, 70 insertions(+), 3 deletions(-)
> > 
> 
> Patches look good, but I cannot push them because they are missing
> your 
> signoff. I can fix it, but I need your permisson to add the following
> at 
> the end of both messages:
> 
>    Signed-off-by: Dawid Zamirski <dzamirski@datto.com>
> 
> This confirms also that you've agreed to Developer Certificate of
> Origin 
> 1.1:
> 
>    https://libvirt.org/hacking.html
> 
> Michal
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php PATCH 0/2] Add binding for virDomainInterfaceAddresses

Posted by Michal Privoznik 3 days ago
On 7/14/19 6:41 AM, Dawid Zamirski wrote:
> Hi Michal,
> 
> Yes, please feel free to add:
> 
> Signed-off-by: Dawid Zamirski <dzamirski@datto.com>
> 
> to both messages. I'll make sure it is included in my future
> submissions from now on.

Cool! I've merged these. Thanks.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list